Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to apkeep 0.16.0, python 3.11 & Debian bookworm #612

Merged
merged 6 commits into from
May 24, 2024
Merged

chore: Upgrade to apkeep 0.16.0, python 3.11 & Debian bookworm #612

merged 6 commits into from
May 24, 2024

Conversation

Jean-BaptisteC
Copy link
Contributor

@Jean-BaptisteC Jean-BaptisteC commented Apr 7, 2024

Fixes #611
Did we need to send a first request to get an aas_token, maybe it can be done manually the first time?

To reduce failed downloads, I use Pixel 7 device to download APK.

Needs help to test :)

Edit : Fixes #598 too

@Porkepix
Copy link
Member

Porkepix commented Apr 7, 2024

Just a heads up on something: is it possible to use/try several devices in case this would be needed? I don't think it would apply to many applications, but maybe some would not allow a device that's too recent?
In case a fallback on an old device would not be possible, it'd anyway be clearly preferred to pick a more recent one considering the too old devices are currently an issue for many applications.
Just gotta keep an eye on this.

@Jean-BaptisteC
Copy link
Contributor Author

Tell me if you want I update the documentation to get the token the first time :)

@codeurimpulsif
Copy link
Contributor

@Jean-BaptisteC I think it could be a good idea for the documentation if you can, yes

@pnu-s
Copy link
Member

pnu-s commented Apr 17, 2024

@Jean-BaptisteC Let's add a link to https://github.com/EFForg/apkeep/blob/master/USAGE-google-play.md in order to not duplicate the information :)

@pnu-s
Copy link
Member

pnu-s commented Apr 17, 2024

Just tested locally and I could make it work, I'll push my changes into this branch @Jean-BaptisteC

@pnu-s pnu-s changed the title Use new apkeep version feat: Upgrade to apkeep 0.16.0, python 3.11 & Debian bookworm Apr 17, 2024
@pnu-s pnu-s changed the title feat: Upgrade to apkeep 0.16.0, python 3.11 & Debian bookworm chore: Upgrade to apkeep 0.16.0, python 3.11 & Debian bookworm Apr 17, 2024
@Jean-BaptisteC
Copy link
Contributor Author

Why device has been removed?

@pnu-s
Copy link
Member

pnu-s commented Apr 17, 2024

The default device is px_7a (see apkeep's doc) which is the one we wanted.

Specifying lynx was not working correctly, so I removed it.

Copy link
Contributor

@codeurimpulsif codeurimpulsif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and tested with Docker.

Work like a charm! I can also confirm that applications we could not download before are now downloadable.

Thanks everyone.

@codeurimpulsif codeurimpulsif changed the title chore: Upgrade to apkeep 0.16.0, python 3.11 & Debian bookworm WIP: chore: Upgrade to apkeep 0.16.0, python 3.11 & Debian bookworm Apr 20, 2024
@codeurimpulsif codeurimpulsif changed the title WIP: chore: Upgrade to apkeep 0.16.0, python 3.11 & Debian bookworm chore: Upgrade to apkeep 0.16.0, python 3.11 & Debian bookworm Apr 20, 2024
@codeurimpulsif codeurimpulsif marked this pull request as draft April 20, 2024 12:49
@codeurimpulsif
Copy link
Contributor

Converted to draft so we don't merge it before our production is upgraded to Debian 12 soon!

@codeurimpulsif codeurimpulsif marked this pull request as ready for review May 24, 2024 16:24
@pnu-s pnu-s merged commit 19bcff9 into Exodus-Privacy:v1 May 24, 2024
8 checks passed
@Jean-BaptisteC Jean-BaptisteC deleted the apkeep_v16 branch May 24, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants