Use exceptional versions from JSON #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richlander
reviewed
Aug 30, 2024
| @@ -4,4 +4,6 @@ public record ReportOverview(DateTime Timestamp, string Version, IList<ReportFam | |||
|
|
|||
| public record ReportFamily(string Name, IList<ReportDistribution> Distributions); | |||
|
|
|||
| public record ReportDistribution(string Name, IList<string> ActiveReleases, IList<string> ActiveReleasesUnsupported, IList<string> ActiveReleasesEOLSoon, IList<string> NotActiveReleasesSupported, IList<string> NotActiveReleasesUnsupported, IList<string> ReleasesMissing); | |||
| public record ReportDistribution(string Name, IList<string> ActiveReleases, IList<string> ActiveReleasesUnsupported, IList<string> ActiveReleasesEOLSoon, IList<string> NotActiveReleasesSupported, IList<string> NotActiveReleasesUnsupported, IList<string> ReleasesMissing, IList<ReportException> Exceptions); | |||
There was a problem hiding this comment.
IList<ReportException> Exceptions
Could we make this an IList<ExceptionalVersion> ? We can re-use the types from the other project and then we can simplify the code (no foreach).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/core#9431
@richlander A POC on how to handle the data
iffwe would make the adjustments to the schema as POC'd in Falco20019/core#2