support snapshot versioning #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 16, 2023
|
CLA received, will review. |
|
Some changes to behavior are acceptable for minor version, so 2.16 is probably good target (more so than 2.15, don't want behavior change in a patch). |
| @@ -113,7 +113,8 @@ public String toFullString() { | |||
| } | |||
|
|
|||
| @Override public int hashCode() { | |||
| return _artifactId.hashCode() ^ _groupId.hashCode() + _majorVersion - _minorVersion + _patchLevel; | |||
| return _artifactId.hashCode() ^ _groupId.hashCode() ^ _snapshotInfo.hashCode() | |||
There was a problem hiding this comment.
_snapshotInfo typically null. Will change to check.
There was a problem hiding this comment.
Actually, n/m, no null prevented in constructor. All good. :)
cowtowncoder
approved these changes
Jun 18, 2023
dmikurube
added a commit
to embulk/embulk-util-config
that referenced
this pull request
Apr 3, 2024
The test has started to fail since Jackson 2.16.0 because of the following changes: - FasterXML/jackson-core#1053 - FasterXML/jackson-core#1142 These were "fixing" the following issues: - FasterXML/jackson-core#1050 - FasterXML/jackson-core#1141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could change default behavior for clients, so I expect it should be merged into master instead of here.
I have proposed two PRs, one for the current version, and one for master assuming this is unacceptable.
I expect and recommend that this PR be closed without merging because it is a non-backwards-compatible change, but wanted to offer it nonetheless.
Closes #1050
Same as #1054 but rebased onto
2.16