Use LazyString in depwarn #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lassepe
reviewed
Mar 18, 2024
lassepe
reviewed
Mar 18, 2024
Co-authored-by: Lasse Peters <[email protected]>
mcabbott
commented
Mar 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2400 +/- ##
=======================================
Coverage 43.04% 43.04%
=======================================
Files 32 32
Lines 1856 1856
=======================================
Hits 799 799
Misses 1057 1057 ☔ View full report in Codecov by Sentry. |
CarloLucibello
approved these changes
Mar 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2399
Maybe there are a few other cases we should do this?