Implementing AST properties using singleton edge lists #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
better-property-edges
branch
from
9d732fc
to
37cdb1d
Compare
oxisto
force-pushed
the
ast-property-edges
branch
5 times, most recently
from
9250c6d
to
676f48a
Compare
oxisto
requested review from
KuechA,
peckto,
maximiliankaul and
konradweiss
as code owners
KuechA
reviewed
Aug 15, 2024
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/ExpressionBuilder.kt
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/edges/EdgeWalker.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/edges/EdgeWalker.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/edges/Extensions.kt
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/edges/collections/EdgeSingletonList.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/statements/IfStatement.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/statements/IfStatement.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/statements/IfStatement.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/statements/expressions/CastExpression.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/helpers/SubgraphWalker.kt
Outdated
Show resolved
Hide resolved
oxisto
force-pushed
the
ast-property-edges
branch
3 times, most recently
from
72b2df4
to
7bf397e
Compare
5 tasks
KuechA
reviewed
Aug 26, 2024
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/statements/ForEachStatement.kt
Show resolved
Hide resolved
KuechA
approved these changes
Aug 29, 2024
oxisto
force-pushed
the
ast-property-edges
branch
from
4d94f90
to
31e0b65
Compare
|
I want to do another small clean up pass before merging. |
|
This was referenced Sep 1, 2024
maximiliankaul
pushed a commit
that referenced
this pull request
Sep 5, 2024
* Implementing AST properties using singleton edge lists This PR is a tryout * Adding mission relationship annotation * remove one more addStatement * Some additional cleanup * Slightly better naeming for delegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements AST edges for all AST properties. Because of a bug (or rather "known limitation") of Neo4J OGM we need to be a bit tricky in assigning AST edges to single-node properties. Specifically, we need to wrap them into a singleton list of one element.
The major advantage is two-fold:
astParentin the constructor of theAstEdge(and probably do other things as well)There is a new
allEdges/edgesfunction as well as a new shortcutastEdgesto retrieve all AST edges starting from a certain node.