-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[for fleet provisioning with CSR to support write key and certificate to disk] support optional write generated private key #183
[for fleet provisioning with CSR to support write key and certificate to disk] support optional write generated private key #183
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 94.02% 94.02%
=======================================
Files 3 3
Lines 1689 1689
Branches 442 442
=======================================
Hits 1588 1588
Misses 17 17
Partials 84 84
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Hey, thanks for submitting all the PRs you've raised to add in this feature! I do like this idea, as I can see how useful it is for debugging. That said, I think using this feature in the file should generate a |
Co-authored-by: Soren Ptak <[email protected]>
Co-authored-by: Soren Ptak <[email protected]>
Thanks @Skptak for the review I'll also add the compilation warning shortly |
/bot run formatting |
Support optional write generated private key to disk
Description
For use by the fleet provisioning with CSR demo ( see https://github.com/giuspen/aws-iot-device-sdk-embedded-C/tree/GP_fleet_provisioning_with_csr_demo/demos/fleet_provisioning/fleet_provisioning_with_csr ), I would like to support writing key and certificate to disk when the optional macros DOWNLOADED_CERT_WRITE_PATH and GENERATED_PRIVATE_KEY_WRITE_PATH are provided
Checklist: