Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[for fleet provisioning with CSR to support write key and certificate to disk] support optional write generated private key #183

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

giuspen
Copy link
Contributor

@giuspen giuspen commented Oct 19, 2023

Support optional write generated private key to disk

Description

For use by the fleet provisioning with CSR demo ( see https://github.com/giuspen/aws-iot-device-sdk-embedded-C/tree/GP_fleet_provisioning_with_csr_demo/demos/fleet_provisioning/fleet_provisioning_with_csr ), I would like to support writing key and certificate to disk when the optional macros DOWNLOADED_CERT_WRITE_PATH and GENERATED_PRIVATE_KEY_WRITE_PATH are provided

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd53f1b) 94.02% compared to head (a4d1f61) 94.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   94.02%   94.02%           
=======================================
  Files           3        3           
  Lines        1689     1689           
  Branches      442      442           
=======================================
  Hits         1588     1588           
  Misses         17       17           
  Partials       84       84           
Flag Coverage Δ
unit_tests 94.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
source/portable/mbedtls/core_pkcs11_mbedtls.c 93.93% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Skptak
Copy link
Member

Skptak commented Oct 19, 2023

Hey, thanks for submitting all the PRs you've raised to add in this feature!
I've commented two smaller nits that I saw in your changes on this PR.

I do like this idea, as I can see how useful it is for debugging. That said, I think using this feature in the file should generate a #warning just to make sure that it isn't accidentally left in.

@giuspen
Copy link
Contributor Author

giuspen commented Oct 20, 2023

Thanks @Skptak for the review I'll also add the compilation warning shortly

@giuspen
Copy link
Contributor Author

giuspen commented Oct 20, 2023

/bot run formatting

@manvensh manvensh requested a review from Skptak October 27, 2023 19:15
@manvensh manvensh requested review from Skptak and removed request for Skptak October 30, 2023 21:47
@ActoryOu ActoryOu merged commit c671c11 into FreeRTOS:main Nov 9, 2023
14 checks passed
@giuspen giuspen deleted the GP_SupportWriteGeneratedPrivateKey branch November 9, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants