Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[for fleet provisioning with CSR to support write key and certificate to disk] support optional write generated private key #183

Merged
merged 7 commits into from
Nov 9, 2023
Merged

[for fleet provisioning with CSR to support write key and certificate to disk] support optional write generated private key #183

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a825baf
added optional support for writing to disk GENERATED_PRIVATE_KEY_WRIT…
Oct 19, 2023
57793bd
just moved include and define to top of C file
Oct 19, 2023
942f8c9
Update source/portable/mbedtls/core_pkcs11_mbedtls.c
giuspen Oct 20, 2023
2788b19
Update source/portable/mbedtls/core_pkcs11_mbedtls.c
giuspen Oct 20, 2023
7262830
added warning when GENERATED_PRIVATE_KEY_WRITE_PATH defined
Oct 20, 2023
f1eebfa
Uncrustify: triggered by comment.
actions-user Oct 20, 2023
a4d1f61
empty commit to trigger CI
ActoryOu Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions source/portable/mbedtls/core_pkcs11_mbedtls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@
/* C runtime includes. */
#include <string.h>

#if defined( GENERATED_PRIVATE_KEY_WRITE_PATH )
#warning "GENERATED_PRIVATE_KEY_WRITE_PATH was defined. C_GenerateKeyPair will write generated private keys to that filepath"
#include <errno.h>
#define PRIV_KEY_BUFFER_LENGTH 2048
#endif /* defined( GENERATED_PRIVATE_KEY_WRITE_PATH ) */

/*-----------------------------------------------------------*/

/**
Expand Down Expand Up @@ -5676,6 +5682,41 @@ CK_DECLARE_FUNCTION( CK_RV, C_GenerateKeyPair )( CK_SESSION_HANDLE hSession,
mbedtlsLowLevelCodeOrDefault( lMbedTLSResult ) ) );
xResult = CKR_FUNCTION_FAILED;
}
else
{
#if defined( GENERATED_PRIVATE_KEY_WRITE_PATH )
char privatekey[ PRIV_KEY_BUFFER_LENGTH ];
lMbedTLSResult = mbedtls_pk_write_key_pem( &xCtx, privatekey, PRIV_KEY_BUFFER_LENGTH );

if( lMbedTLSResult == 0 )
{
size_t privatekeyLength = strlen( privatekey );
FILE * fp = fopen( GENERATED_PRIVATE_KEY_WRITE_PATH, "w" );

if( NULL != fp )
{
const size_t writtenBytes = fwrite( privatekey, 1u, privatekeyLength, fp );

if( writtenBytes == privatekeyLength )
{
LogInfo( ( "Wrote the generated private key to %s successfully.", GENERATED_PRIVATE_KEY_WRITE_PATH ) );
}
else
{
LogError( ( "Could not write to %s. Error: %s.", GENERATED_PRIVATE_KEY_WRITE_PATH, strerror( errno ) ) );
}

fclose( fp );
}
else
{
LogError( ( "Could not open %s. Error: %s.", GENERATED_PRIVATE_KEY_WRITE_PATH, strerror( errno ) ) );
}
}
#else /* if defined( GENERATED_PRIVATE_KEY_WRITE_PATH ) */
LogInfo( ( "NOTE: define GENERATED_PRIVATE_KEY_WRITE_PATH in order to have the private key written to disk." ) );
#endif // GENERATED_PRIVATE_KEY_WRITE_PATH
}
}

if( xResult == CKR_OK )
Expand Down