Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to python 3.12, test versions 3.8 - 3.12 #28

Merged
merged 8 commits into from
Sep 26, 2024

Conversation

johnjeffers
Copy link
Contributor

@johnjeffers johnjeffers commented Sep 26, 2024

Python 3.8 is EOL next month. Upgrading to latest stable version 3.12 gets us 4 more years. https://devguide.python.org/versions/

Other changes:

  • run the tests as a matrix that tests python major versions 3.8 thru 3.12.
  • rewrite the test workflow to use a github runner as self-hosted is not required
  • rewrite the test workflow to run tests in a python venv to avoid warnings about running as root
  • upgrade postgres version in docker compose file to 16.4

@johnjeffers johnjeffers requested review from a team as code owners September 26, 2024 17:41
robotdan
robotdan previously approved these changes Sep 26, 2024
.python-version Outdated
@@ -1 +1 @@
3.8.13
3.10.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably update the dev setup to ensure 3.10 is installed on our dev boxes as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's already in my plan, and literally the whole reason I started looking into this :)

@mooreds
Copy link
Contributor

mooreds commented Sep 26, 2024

While you are in here, would be great to replace the bespoke docker compose setup with the released fusionauth github action.

Action here: https://github.com/marketplace/actions/fusionauth-action

Example using a kickstart: https://github.com/FusionAuth/fusionauth-theme-history-updater/blob/main/.github/workflows/update-theme-history.yml#L69

@johnjeffers
Copy link
Contributor Author

While you are in here, would be great to replace the bespoke docker compose setup with the released fusionauth github action.

Action here: https://github.com/marketplace/actions/fusionauth-action

Example using a kickstart: https://github.com/FusionAuth/fusionauth-theme-history-updater/blob/main/.github/workflows/update-theme-history.yml#L69

Cool, will do

@mooreds
Copy link
Contributor

mooreds commented Sep 26, 2024

Also how does this change get into the release notes? Do we need a tracking issue attached to the 1.54 milestone?

@johnjeffers johnjeffers changed the title upgrade to python 3.10 upgrade to python 3.12, test versions 3.8 - 3.12 Sep 26, 2024
@johnjeffers
Copy link
Contributor Author

Also how does this change get into the release notes? Do we need a tracking issue attached to the 1.54 milestone?

@robotdan @wied03 Correct me if I'm wrong, but I don't think this is going to have any impact to customers, as long as we continue to test older versions as well as new, which this PR addresses.

However... I'm not sure if I should be updating the version in build.savant or not for this change, or whether that should happen as part of the regular 1.54 release process. If not, let me know and I'll roll that back.

@wied03
Copy link
Contributor

wied03 commented Sep 26, 2024

Also how does this change get into the release notes? Do we need a tracking issue attached to the 1.54 milestone?

@robotdan @wied03 Correct me if I'm wrong, but I don't think this is going to have any impact to customers, as long as we continue to test older versions as well as new, which this PR addresses.

BW: I agree it won't have an effect.

However... I'm not sure if I should be updating the version in build.savant or not for this change, or whether that should happen as part of the regular 1.54 release process. If not, let me know and I'll roll that back.

BW: I think ideally this PR targets develop, which is already at 1.54.0. Then when release happens, this would all be 'included' in that.

build.savant Outdated Show resolved Hide resolved
.github/workflows/test.yaml Show resolved Hide resolved
@wied03
Copy link
Contributor

wied03 commented Sep 26, 2024

Also how does this change get into the release notes? Do we need a tracking issue attached to the 1.54 milestone?

Does it need to be? If the library is still tested with the version it was before, then I think its compatibility hasn't changed, right?

@johnjeffers johnjeffers changed the base branch from main to develop September 26, 2024 19:14
setup.py Outdated Show resolved Hide resolved
@robotdan
Copy link
Member

I don't know if this needs to be in release notes unless there is a reason to think it will affect anyone. I think all this does it cause us to use a newer point version (semver compatible) to build our python client.

Anyone using this client presumably can still use a Python runtime older than this since it should be a compatible change as far as I am aware.

@johnjeffers johnjeffers merged commit 447ff24 into develop Sep 26, 2024
5 checks passed
@johnjeffers johnjeffers deleted the jj/python-3.10 branch September 26, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants