Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to python 3.12, test versions 3.8 - 3.12 #28

Merged
merged 8 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# Run locally with act:
#
# act pull_request \
# --platform fusionauth-standard=[ecr-repo-name]/fusionauth-standard:latest] \
# --workflows ./.github/workflows/test.yaml
# act pull_request --workflows .github/workflows/test.yaml

name: Test

Expand All @@ -17,7 +15,7 @@ on:

jobs:
run_tests:
runs-on: fusionauth-standard
runs-on: ubuntu-latest
env:
FUSIONAUTH_URL: http://localhost:9011
FUSIONAUTH_API_KEY: bf69486b-4733-4470-a592-f1bfce7af580
Expand All @@ -28,16 +26,19 @@ jobs:
working-directory: src/test/docker
run: docker compose up -d

- name: Install fusionauth library
shell: bash -l {0}
run: pip3 install .

- name: Check to see if FusionAuth is loaded
run: |
bash ./src/test/docker/poll-for-kickstart-finish.sh

- name: Run tests
shell: bash -l {0}
run: |
python3 src/test/python/fusionauth/rest_client_test.py
python3 src/test/python/fusionauth/fusionauth_client_test.py
python3 -m venv .venv
source .venv/bin/activate
echo -e "\nUsing $(python --version) in $(which python)\n"
pip install -e .
echo ""
pip list
echo ""
python src/test/python/fusionauth/rest_client_test.py
python src/test/python/fusionauth/fusionauth_client_test.py
2 changes: 1 addition & 1 deletion .python-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.8.13
3.10.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably update the dev setup to ensure 3.10 is installed on our dev boxes as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's already in my plan, and literally the whole reason I started looking into this :)

2 changes: 1 addition & 1 deletion fusionauth-python-client.iml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<excludeFolder url="file://$MODULE_DIR$/build" />
<excludeFolder url="file://$MODULE_DIR$/dist" />
</content>
<orderEntry type="jdk" jdkName="Python 3.8" jdkType="Python SDK" />
<orderEntry type="jdk" jdkName="Python 3.10" jdkType="Python SDK" />
<orderEntry type="sourceFolder" forTests="false" />
</component>
</module>
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

setup(
name="fusionauth-client",
version="1.54.0",
version="1.53.2",
wied03 marked this conversation as resolved.
Show resolved Hide resolved
author="FusionAuth",
author_email="[email protected]",
description="A client library for FusionAuth",
Expand Down
2 changes: 1 addition & 1 deletion src/test/docker/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
db:
image: postgres:16.0-alpine
image: postgres:16.4-alpine
environment:
PGDATA: /var/lib/postgresql/data/pgdata
POSTGRES_USER: postgres
Expand Down