-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Notification - application status changed #10372
[Feature] Notification - application status changed #10372
Conversation
@gobyrne or @marc-donofrio could you please review the email templates in GCNotify? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10372 +/- ##
============================================
+ Coverage 37.10% 38.40% +1.30%
- Complexity 1332 1345 +13
============================================
Files 980 984 +4
Lines 29952 30140 +188
Branches 6489 6500 +11
============================================
+ Hits 11113 11575 +462
+ Misses 18804 18391 -413
- Partials 35 174 +139
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
β¦lication-status-changed-part2
*/ | ||
public function toGcNotifyEmail(User $notifiable): GcNotifyEmailMessage | ||
{ | ||
$locale = $this->locale ?? $notifiable->preferredLocale(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does $this->locale
come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notification can have its locale explicitly set when it is created.
https://laravel.com/docs/10.x/notifications#localizing-notifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! Works as expected.
I noticed one little hicough, but I think its out of scope for this one. When I clicked the in-app notification, which links to http://localhost:8000/en/applicant#track-applications-section, and I was already on the page http://localhost:8000/en/applicant, then I wasn't scrolled to the correct section.
π€ Resolves #9642
π Introduction
This branch adds a new notification - application status changed - for both in-app and email.
π΅οΈ Details
Add any additional details that could assist with reviewing or testing this PR.
π§ͺ Testing
πΈ Screenshot
π Deployment