Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid example GeoJSON in swagger #835

Merged
merged 7 commits into from
Oct 10, 2024
Merged

fix: invalid example GeoJSON in swagger #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a87b72f
fix: invalid example GeoJSON in swagger
Gigaszi Oct 10, 2024
e9b4c7d
chore: update CHANGELOG.md
Gigaszi Oct 10, 2024
ba91976
fix: invalid example GeoJSON in swagger
Gigaszi Oct 10, 2024
7fe2b1e
chore: update CHANGELOG.md
Gigaszi Oct 10, 2024
3dbd014
Merge branch '831-swagger-error' of https://github.com/GIScience/ohso…
Gigaszi Oct 10, 2024
18b8322
test: fix tests by adjusting to new data/numbers
mmerdes Oct 10, 2024
df6b2ce
Merge branch 'main' into 831-swagger-error
Gigaszi Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,13 @@

### Bug Fixes

- fix: invalid example GeoJSON in swagger ([#831])
- fix: global coverage is now returned correctly ([#821])


[#821]: https://github.com/GIScience/ohsome-quality-api/issues/821
[#831]: https://github.com/GIScience/ohsome-quality-api/issues/831
[#832]: https://github.com/GIScience/ohsome-quality-api/issues/832


## Release 1.5.0
Expand Down
3 changes: 2 additions & 1 deletion ohsome_quality_api/api/request_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ class BaseBpolys(BaseConfig):
]
],
},
},
"properties": {},
}
],
}
)
Expand Down
2 changes: 1 addition & 1 deletion regression-tests/roads_polygon_attributecompleteness.hurl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ bytes count > 1900

jsonpath "$.result[0].metadata.name" == "Attribute Completeness"
jsonpath "$.result[0].topic.name" == "Roads"
jsonpath "$.result[0].result.description" contains "The ratio of the features (all: 1034299.9) compared to features with expected tags (matched: 276785.2) is 0.27."
jsonpath "$.result[0].result.description" contains "The ratio of the features (all: 1034408.4) compared to features with expected tags (matched: 278118.2) is 0.27. Around 25-75% of the features match the expected tags."
jsonpath "$.result[0].result.figure.data[0].gauge.steps[0].color" == "tomato"
jsonpath "$.result[0].result.label" == "yellow"

Expand Down
2 changes: 1 addition & 1 deletion regression-tests/roads_polygon_mappingsaturation.hurl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ status == 200
bytes count > 24000

jsonpath "$.result[0].topic.name" == "Roads"
jsonpath "$.result[0].result.description" contains "The saturation of the last 3 years is 98.3%.High saturation has been reached (97% < Saturation ≤ 100%)."
jsonpath "$.result[0].result.description" contains "The saturation of the last 3 years is 98.46%.High saturation has been reached (97% < Saturation ≤ 100%)."
jsonpath "$.result[0].result.figure.data[0].line.color" == "#2185D0"
jsonpath "$.result[0].result.label" == "green"

Expand Down