Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid example GeoJSON in swagger #835

Merged
merged 7 commits into from
Oct 10, 2024
Merged

fix: invalid example GeoJSON in swagger #835

merged 7 commits into from
Oct 10, 2024

Conversation

Gigaszi
Copy link
Collaborator

@Gigaszi Gigaszi commented Oct 10, 2024

Add missing properties dict to example GeoJSON.

Corresponding issue

Closes #831

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
    - [ ] I have commented my code
    - [ ] I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

@mmerdes mmerdes self-requested a review October 10, 2024 10:16
Copy link
Collaborator

@mmerdes mmerdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please consider referencing the issue instead of the PR.

CHANGELOG.md Outdated
@@ -2,6 +2,13 @@

## Current Main

### Bug Fixes

- fixed invalid example GeoJSON in swagger ([#835])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could reference the issue itself here (#831) rather than the PR.
Or do you see an advantage in using the PR?
The issue is a more permanent thing compared to the PR.

@Gigaszi Gigaszi merged commit d0cce02 into main Oct 10, 2024
1 of 2 checks passed
@Gigaszi Gigaszi deleted the 831-swagger-error branch October 10, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping Saturation and Currentness Request Fail with Validation Error
2 participants