Evaluation Form Validation - Part 2

[stepchud]

User story

As a challenge manager, in order to ensure that a valid form is available for the evaluators to use, I would like a form to be validated for errors and valid logic before it is saved.

Technical Notes

This will require moving away from html5 validation in the browser. The new validation will happen after the user submits the form. The controller will validate the EvalForm and EvalCriteria on the backend and return the validation errors to the frontend if it fails.

Acceptance Criteria:

• Inline error validation is provided for missing required fields or invalid input
• If there are any form validation errors upon saving the form, an error message is displayed at the top of the page and invalid fields are highlighted
  • The form is not saved until errors are resolved
• If there are any validation errors for the criteria fields (for example, due to scale type change), accordions are expanded and invalid fields are highlighted
  • Weighted scoring summing up to 100 and unique criteria titles do not require inline validation errors on each criteria

Definition of Done

Doing (dev team)

• Code complete
• Code is organized appropriately
• Any known trade offs are documented in the associated GH issue
• Code is documented, modules, shared functions, etc.
• Automated testing has been added or updated in response to changes in this PR
• The feature is smoke tested to confirm it meets requirements
• Database changes have been peer reviewed for index changes and performance bottlenecks
• PR that changes or adds UI
  • include a screenshot of the WAVE report for the altered pages
  • Confirm changes were validated for mobile responsiveness
• PR approved / Peer reviewed
• Security scans passed
• Automate accessibility tests passed
• Build process and deployment is automated and repeatable
• Feature toggles if appropriate
• Deploy to staging
• Move card to testing column in the board

---

Staging

• 12/23/24 RB note: Below items were tested with Evaluation Form Validation - Part 1 #181
• Usability testing: mobile and desktop (Tracy or Marni)
• Accessibility tested (Marni)
  • Keyboard navigation
  • Focus confirmed
  • Color contrast compliance
  • Screen reader testing
• Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)
  • Windows/Chrome
  • Windows/Edge
  • Mac/Chrome
  • Mac/Safari
  • iOS/Safari
• AC review (Renata)
• Deploy to production (production-like environment for eval capability) (dev team)
• Move to production column in the board

---

Production

• User and security documentation has been reviewed for necessary updates (Renata/Tracy/Dev team)
• PO / PM approved (Jarah or Renata)
• AC is met and it works as expected (Jarah or Renata)
• Move to done column in the board (Jarah or Renata)

[r-bartlett-gsa]

@stepchud / @cpreisinger Added the AC, please verify it's inline with what we discussed.

[r-bartlett-gsa]