Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[296] Evaluation Form Validation - Part 2 #327

Merged
merged 15 commits into from
Dec 18, 2024
Merged

[296] Evaluation Form Validation - Part 2 #327

merged 15 commits into from
Dec 18, 2024

Conversation

cpreisinger
Copy link
Contributor

@cpreisinger cpreisinger commented Dec 17, 2024 •
edited
Loading

#296
#67

List of some updates

  • Form can be submitted without everything filled in and will show inline errors
  • Having non unique eval criteria will highlight those fields
  • Having weights not adding up to 100 for weighted scale type will highlight those fields
  • Move the tooltip icon outside of checkbox selector
  • When another criteria is added auto-collapse the previous criteria
  • Criteria Points/Weight input field should sit below title
  • Remove criteria points field placeholder text, it's not necessary
  • Removing a criteria requires a removal confirmation modal

@cpreisinger cpreisinger self-assigned this Dec 17, 2024
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 12/17/24 milestone Dec 17, 2024
@r-bartlett-gsa r-bartlett-gsa linked an issue Dec 17, 2024 that may be closed by this pull request
Evaluation Form Validation - Part 2 #296
Closed
41 tasks
@cpreisinger cpreisinger requested a review from stepchud December 17, 2024 18:48
stepchud
stepchud reviewed Dec 17, 2024
View reviewed changes
db/migrate/20241217164258_change_weighted_scoring_in_evaluation_forms.rb
add_column :evaluation_forms, :scale_type, :string

EvaluationForm.reset_column_information
EvaluationForm.find_each do |form|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

stepchud
stepchud reviewed Dec 18, 2024
View reviewed changes
app/controllers/evaluation_forms_controller.rb
@@ -2,6 +2,8 @@

# Controller for evaluation forms CRUD actions.
class EvaluationFormsController < ApplicationController
helper FormHelper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't necessary, the helpers are automatically included on every controller

@stepchud stepchud merged commit 0788919 into dev Dec 18, 2024
11 checks passed
@stepchud stepchud deleted the 296/evaluation-form-validation-part-2 branch December 18, 2024 20:44
@stepchud stepchud mentioned this pull request Dec 18, 2024
Closed
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepchud stepchud stepchud approved these changes

Assignees

@cpreisinger cpreisinger

Labels
ready for review
Projects
None yet
Milestone
Sprint 12/31/24
Development

Successfully merging this pull request may close these issues.

Evaluation Form Validation - Part 2
3 participants
@cpreisinger @stepchud @r-bartlett-gsa