Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[181] Evaluation Form Validation - Part 1 #316

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

cpreisinger
Copy link
Contributor

@cpreisinger cpreisinger commented Dec 10, 2024

#181

Reason for changes

Persisted checks were originally added so new forms didn't show criteria sections like option labels before a radio button was checked and to make sure there were no default selected options.

I switched this to just checking if the value exists since a form validation error would cause parts of the form to not display on newly created forms if they failed validation since they technically didn't "persist"

Steps to test

  • Create a new eval form
  • Fill out all form data
  • Add at least one criteria with either binary/rating scale to see option labels
  • Force a validation error that still allows submission in one of two ways:
    • Have two criteria with the same title
    • Have scale type as weighted with criteria that do not sum to 100
  • Form should still have the scale type selected
  • Form should still show option labels for binary/rating criteria

Same should hold true on editing a form

@cpreisinger cpreisinger self-assigned this Dec 10, 2024
@cpreisinger cpreisinger changed the title [181 296] Evaluation Form Validation - Part 1 && 2 [181 | 296] Evaluation Form Validation - Part 1 && 2 Dec 10, 2024
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 12/17/24 milestone Dec 10, 2024
@stepchud stepchud changed the title [181 | 296] Evaluation Form Validation - Part 1 && 2 [181] Evaluation Form Validation - Part 1 Dec 10, 2024
cpreisinger and others added 3 commits December 11, 2024 00:18
…-form-validation

* 'dev' of github.com:GSA/Challenge_platform:
  Bump rubocop from 1.68.0 to 1.69.1
  Bump selenium-webdriver from 4.26.0 to 4.27.0
  [304] Collapsible Column Layout (#310)
@stepchud stepchud self-requested a review December 12, 2024 07:06
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@stepchud stepchud merged commit 348d3af into dev Dec 12, 2024
11 checks passed
@stepchud stepchud deleted the 181/eval-form-validation branch December 12, 2024 07:15
@r-bartlett-gsa r-bartlett-gsa linked an issue Dec 13, 2024 that may be closed by this pull request
5 tasks
@r-bartlett-gsa r-bartlett-gsa modified the milestone: Sprint 12/17/24 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants