[181] Evaluation Form Validation - Part 1 #316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#181
Reason for changes
Persisted checks were originally added so new forms didn't show criteria sections like option labels before a radio button was checked and to make sure there were no default selected options.
I switched this to just checking if the value exists since a form validation error would cause parts of the form to not display on newly created forms if they failed validation since they technically didn't "persist"
Steps to test
Same should hold true on editing a form