Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation-status-has-remarks Constraint #1018

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Gabeblis
Copy link
Contributor

Committer Notes

Purpose

This PR aims to add the implementation-status-has-remarks constraint which ensures that SSP statements include (via by-component assembly) with the following implementation status (partial, planned, alternative, or not-applicable) have remarks.

Changes

Added constraint:

  • implementation-status-has-remarks

Added valid/invalid test content:

  • ssp-implementation-status-has-remarks-INVALID.xml

Added yaml files for testing:

  • Pass/fail yaml tests added for each of the above constraints.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Dec 17, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner December 17, 2024 20:11
Copy link
Member

@Rene2mt Rene2mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!!

@wandmagic wandmagic merged commit c473021 into GSA:develop Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Controls - SSP by-component assemblies with certain implementation-status have remarks
3 participants