Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation-status-has-remarks Constraint #1018

Merged
merged 1 commit into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions features/fedramp_extensions.feature
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ Examples:
| has-system-id |
| has-system-name-short |
| has-user-guide |
| implementation-status-has-remarks |
| import-profile-has-available-document |
| import-profile-resolves-to-fedramp-content |
| incomplete-implemented-requirements |
Expand Down Expand Up @@ -314,6 +315,8 @@ Examples:
| has-system-name-short-PASS.yaml |
| has-user-guide-FAIL.yaml |
| has-user-guide-PASS.yaml |
| implementation-status-has-remarks-FAIL.yaml |
| implementation-status-has-remarks-PASS.yaml |
| import-profile-has-available-document-FAIL.yaml |
| import-profile-has-available-document-PASS.yaml |
| import-profile-resolves-to-fedramp-content-FAIL.yaml |
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<system-security-plan xmlns="http://csrc.nist.gov/ns/oscal/1.0" uuid="11111111-2222-4000-8000-000000000000">
<control-implementation>
<implemented-requirement uuid="11111111-2222-4000-8000-012000000001" control-id="ac-1">
<statement statement-id="ac-1_smt.a.1" uuid="11111111-2222-4000-8000-013000000001">
<by-component component-uuid="11111111-2222-4000-8000-009000000000" uuid="11111111-2222-4000-8000-014000000001">
<implementation-status state="planned"/>
<!-- <remarks>
<p>The specified component is the system itself.</p>
<p>Any control implementation response that can not be associated with another component is associated with the component representing the system.</p>
</remarks> Implementation status is not "implemented", therefore it is missing remarks to provide context. -->
</by-component>
</statement>
</implemented-requirement>
</control-implementation>
</system-security-plan>
11 changes: 11 additions & 0 deletions src/validations/constraints/fedramp-external-constraints.xml
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,17 @@
</constraints>
</context>

<context>
<metapath target="/system-security-plan/control-implementation/implemented-requirement/statement/by-component"/>
<constraints>
<expect id="implementation-status-has-remarks" target="implementation-status[@state=('partial', 'planned', 'alternative', 'not-applicable' )]" test="exists(remarks)" level="ERROR">
<formal-name>Implementation Status Has Remarks</formal-name>
<prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/6-security-controls/#implementation-status"/>
<message>In a FedRAMP SSP, each by-component that is not implemented MUST have remarks to provide context.</message>
</expect>
</constraints>
</context>

<context>
<metapath target="/system-security-plan/system-characteristics/authorization-boundary/diagram/link"/>
<constraints>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
test-case:
name: Negative Test for implementation-status-has-remarks
description: >-
This test case validates the behavior of constraint
implementation-status-has-remarks
content: ../content/ssp-implementation-status-has-remarks-INVALID.xml
expectations:
- constraint-id: implementation-status-has-remarks
result: fail
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
test-case:
name: Positive Test for implementation-status-has-remarks
description: >-
This test case validates the behavior of constraint
implementation-status-has-remarks
content: ../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
expectations:
- constraint-id: implementation-status-has-remarks
result: pass
Loading