Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system-characteristics 'has-security' constraints #669

Conversation

Gabeblis
Copy link

@Gabeblis Gabeblis commented Sep 10, 2024

Committer Notes

Description

Added system-characteristics 'has-security' constraints and tests for each of the constraints. These should be added as they are part of the effort write all of the constraints from the constraint tracker.

Changes

  • Added constraints has-security-sensitivity-level, has-security-impact-level, has-security-objective-confidentiality, has-security-objective-integrity, has-security-objective-availability to fedramp-external-constraints.xml.
  • Added pass and fail yaml tests for all of the above constraints.
  • Edited ssp-all-INVALID.xml to ensure all constraints fail correctly.

{Please provide a description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please submit the PR as a draft PR using the "Draft pull request" dropdown.}

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis requested a review from a team as a code owner September 10, 2024 13:53
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you @Rene2mt sync on this PR and #610. I know they are different but there is some overlap, so I would like to review synchronously while we are on a call, perhaps tail end of standup today?

@Gabeblis Gabeblis force-pushed the constraints/system-characteristics/has-security branch from 6cf0446 to 1336395 Compare September 10, 2024 15:45
@aj-stein-gsa
Copy link
Contributor

Can you @Rene2mt sync on this PR and #610. I know they are different but there is some overlap, so I would like to review synchronously while we are on a call, perhaps tail end of standup today?

AJ will disregard his own remark given our discussion during today's standup, a more comprehensive review is needed and warranted. @Gabeblis gets tell me "Overruled!" 😆

@Gabeblis Gabeblis force-pushed the constraints/system-characteristics/has-security branch 3 times, most recently from ad5eb6b to 24c6dfb Compare September 11, 2024 16:10
@Gabeblis Gabeblis force-pushed the constraints/system-characteristics/has-security branch 3 times, most recently from 26b0673 to 5f3cfb8 Compare September 20, 2024 18:53
@Gabeblis Gabeblis force-pushed the constraints/system-characteristics/has-security branch 2 times, most recently from a3dec6d to 2cab5e3 Compare September 25, 2024 02:34
@aj-stein-gsa aj-stein-gsa force-pushed the constraints/system-characteristics/has-security branch from 2cab5e3 to f7b5546 Compare September 26, 2024 01:18
@aj-stein-gsa aj-stein-gsa changed the base branch from feature/external-constraints to develop September 26, 2024 01:18
@aj-stein-gsa aj-stein-gsa force-pushed the constraints/system-characteristics/has-security branch from f7b5546 to df78e5d Compare September 26, 2024 01:20
@Gabeblis Gabeblis force-pushed the constraints/system-characteristics/has-security branch from eefd079 to b6b347e Compare October 29, 2024 18:57
@Gabeblis Gabeblis requested a review from a team as a code owner October 29, 2024 18:57
@Gabeblis Gabeblis mentioned this pull request Oct 29, 2024
7 tasks
@Gabeblis Gabeblis force-pushed the constraints/system-characteristics/has-security branch from fe823d3 to 81f172b Compare October 30, 2024 03:09
@aj-stein-gsa aj-stein-gsa merged commit 8cf8e0f into GSA:develop Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚢 Ready to Ship
Development

Successfully merging this pull request may close these issues.

4 participants