Comma escape

[A-Shumway42]

Description

We are trying to find a way to figure out the comma issue for csv's/one-offs when a user has extra commas inside of fields. Added debug statements to help see what's happening in extract_personalisation.

I've added more debug statements to try and figure out where the issue is coming from in the api. The value sent from the front-end during a one-off send is wrapped in quotes like so "July 23, 2024" and everything seems to be correct in the debug statements except for the "To" number. I think the phone number is still being swapped for one of the other values somewhere in the create_job process.

TODO (optional)

• TODO item 1
• TODO item 2
• TODO item ...

Security Considerations

[A-Shumway42]

I believe this is okay to keep here for the moment for debugging purposes.

[A-Shumway42]

Stack trace with the current error I am stuck on.

13:29:54 worker.1    |     message_id = send_to_providers.send_sms_to_provider(notification)
13:29:54 worker.1    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
13:29:54 worker.1    |   File "/Users/andrewshumway/work/notify-api-local/notifications-api/app/delivery/send_to_providers.py", line 124, in send_sms_to_provider
13:29:54 worker.1    |     raise e
13:29:54 worker.1    |   File "/Users/andrewshumway/work/notify-api-local/notifications-api/app/delivery/send_to_providers.py", line 115, in send_sms_to_provider
13:29:54 worker.1    |     message_id = provider.send_sms(**send_sms_kwargs)
13:29:54 worker.1    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
13:29:54 worker.1    |   File "/Users/andrewshumway/work/notify-api-local/notifications-api/app/clients/sms/aws_sns.py", line 99, in send_sms
13:29:54 worker.1    |     raise ValueError("No valid numbers found for SMS delivery")
13:29:54 worker.1    | ValueError: No valid numbers found for SMS delivery
13:29:54 worker.1    | [2024-07-23 13:29:54,719: ERROR/ForkPoolWorker-4] SMS notification delivery for id: 44c39de1-4a02-44eb-ab4e-fd3fc62b3345 failed
13:29:54 worker.1    | Traceback (most recent call last):
13:29:54 worker.1    |   File "/Users/andrewshumway/work/notify-api-local/notifications-api/app/celery/provider_tasks.py", line 114, in deliver_sms
13:29:54 worker.1    |     message_id = send_to_providers.send_sms_to_provider(notification)
13:29:54 worker.1    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
13:29:54 worker.1    |   File "/Users/andrewshumway/work/notify-api-local/notifications-api/app/delivery/send_to_providers.py", line 124, in send_sms_to_provider
13:29:54 worker.1    |     raise e
13:29:54 worker.1    |   File "/Users/andrewshumway/work/notify-api-local/notifications-api/app/delivery/send_to_providers.py", line 115, in send_sms_to_provider
13:29:54 worker.1    |     message_id = provider.send_sms(**send_sms_kwargs)
13:29:54 worker.1    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
13:29:54 worker.1    |   File "/Users/andrewshumway/work/notify-api-local/notifications-api/app/clients/sms/aws_sns.py", line 99, in send_sms
13:29:54 worker.1    |     raise ValueError("No valid numbers found for SMS delivery")
13:29:54 worker.1    | ValueError: No valid numbers found for SMS delivery```

[xlorepdarkhelm]

Looks like a job for isort to make this clear up in the tests. Otherwise, LGTM