Allow resources to be created in controller namespace #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the Terraform task pod and other resources to be created in the namespace that the controller is running in.
Always include both resourceName and resourceNamespace in selector. Previously it was being omitted for backwards-compatibility, but that creates problems when there are Terraform resources in different namespaces and also in the same namespace as the controller, both having the same name. Just assume that any old resources would have been cleaned up before upgrading, and if not, force the user to manually delete them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the Terraform task pod and other resources to be created in the namespace that the controller is running in.
This should address #173.