Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow resources to be created in controller namespace #174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow resources to be created in controller namespace #174

wants to merge 2 commits into from

Commits on Jul 17, 2024

  1. Allow resources to be created in controller namespace 

    This change allows the Terraform task pod and other resources to be
created in the namespace that the controller is running in.
    @adriansuarez
    adriansuarez committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e402c0e View commit details
    Browse the repository at this point in the history

  2. Do not try to be backwards-compatible 

    Always include both resourceName and resourceNamespace in selector.
Previously it was being omitted for backwards-compatibility, but that
creates problems when there are Terraform resources in different
namespaces and also in the same namespace as the controller, both having
the same name.

Just assume that any old resources would have been cleaned up before
upgrading, and if not, force the user to manually delete them.
    @adriansuarez
    adriansuarez committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    1b3ea53 View commit details
    Browse the repository at this point in the history