style: pin ruff version #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
previously approved these changes
Feb 5, 2024
korikuzma
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed a funny bug today. Latest Ruff version designated something as a fail. Added a
noqato ignore it. Pre-commit can only be tagged with specific ruff versions, and it flagged thatnoqaas "unused".In a way, every new minor Ruff update has a chance to be "breaking" (in terms of causing fails in CI that were passing before) so I think it might make general good sense to be pinning this stuff and then updating every 3-6 months unless we see a new feature we really want.
update: ruff 0.2.0 came out in the time between me updating my local environment and actually putting this issue together. Went ahead and just updated it here.