updating version check to 3.12 #1813
Conversation
|
Please squash the commits so that only a single commit gets merged into primary branch related to this change. |
| @@ -126,16 +126,16 @@ def make_release_tree(self, base_dir, files): | |||
| 'Natural Language :: English', | |||
| 'Programming Language :: Python', | |||
| 'Programming Language :: Python :: 3', | |||
There was a problem hiding this comment.
Even this line needs to be removed ?
There was a problem hiding this comment.
It's useful for searchability on package indexes like PyPI, as some users may filter for projects compatible with Python 3 broadly, without specifying a minor version. We should only remove this line if the project does not support all minor versions of Python 3. Correct me if i am wrong.
There was a problem hiding this comment.
Correct me if i am wrong. - I do not know the correct approach here, hence I had asked.
I think it's fine to have this as long as it does not specify that we are compatible with Python 3.0 ? Because we are not anymore.
Is there a way to simulate and verify this ?
There was a problem hiding this comment.
As we are updating python_requires='>=3.8, <=3.12', this ensures that we are compatible only with 3.8 to 3.12.
we can keep the 'Programming Language :: Python :: 3' line, as long as we are not claiming compatibility with all versions of Python 3 (which could lead to confusion). IMO, It's fine to leave it, especially if we later specify the exact minor versions (e.g., Programming Language :: Python :: 3.8, Programming Language :: Python :: 3.12) as well.
sameer-google
force-pushed
the
update-version-check
branch
from
92d07d8 to
91ac6c5
Compare
Squashed the commits and Updated PR description. |
|
The kokoro tests failing in this PR are failing in the previous ones' as well. |
sushantkhanna
merged commit f7b016e
into
GoogleCloudPlatform:master
This PR updates the Python version compatibility for gsutil to support Python 3.8 through 3.12, while dropping support for older versions (3.5, 3.6, and 3.7). The following changes have been made:
gsutil.pyto3.8-3.12.python_requiresandclassifiersinsetup.pyto specify compatibility with Python versions 3.8 to 3.12, removing references to unsupported versions (3.5, 3.6, and 3.7).These updates align the project with the ongoing effort to support the latest Python versions while ensuring compatibility across all tested platforms.