Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating version check to 3.12 #1813

Merged
merged 1 commit into from
Nov 26, 2024
Merged

updating version check to 3.12 #1813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gsutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@
# TODO: gsutil-beta: Distribute a pylint rc file.

ver = sys.version_info
if (ver.major == 2 and ver.minor < 7) or (ver.major == 3 and (ver.minor < 5 or ver.minor > 11)):
if ver.major != 3 or ver.minor < 8 or ver.minor > 12:
sys.exit(
"Error: gsutil requires Python version 2.7 or 3.5-3.11, but a different version is installed.\n"
"Error: gsutil requires Python version 3.8-3.12, but a different version is installed.\n"
"You are currently running Python {}.{}\n"
"Follow the steps below to resolve this issue:\n"
"\t1. Switch to Python 3.5-3.11 using your Python version manager or install an appropriate version.\n"
"\t1. Switch to Python 3.8-3.12 using your Python version manager or install an appropriate version.\n"
"\t2. If you are unsure how to manage Python versions, visit [https://cloud.google.com/storage/docs/gsutil_install#specifications] for detailed instructions.".format(ver.major, ver.minor)
)

Expand Down
10 changes: 5 additions & 5 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,16 +126,16 @@ def make_release_tree(self, base_dir, files):
'Natural Language :: English',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even this line needs to be removed ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's useful for searchability on package indexes like PyPI, as some users may filter for projects compatible with Python 3 broadly, without specifying a minor version. We should only remove this line if the project does not support all minor versions of Python 3. Correct me if i am wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if i am wrong. - I do not know the correct approach here, hence I had asked.
I think it's fine to have this as long as it does not specify that we are compatible with Python 3.0 ? Because we are not anymore.
Is there a way to simulate and verify this ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are updating python_requires='>=3.8, <=3.12', this ensures that we are compatible only with 3.8 to 3.12.

we can keep the 'Programming Language :: Python :: 3' line, as long as we are not claiming compatibility with all versions of Python 3 (which could lead to confusion). IMO, It's fine to leave it, especially if we later specify the exact minor versions (e.g., Programming Language :: Python :: 3.8, Programming Language :: Python :: 3.12) as well.

'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
'Programming Language :: Python :: 3.12',
'Topic :: System :: Filesystems',
'Topic :: Utilities',
],
# Gsutil supports Python 3.5+
python_requires='!=2.*, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, <4',
# Gsutil supports Python 3.8 to 3.12
python_requires='>=3.8, <=3.12',
platforms='any',
packages=find_packages(
exclude=[
Expand Down
Loading