Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove KFP presubmit backend test prow config #2296

Merged

Conversation

DharmitD
Copy link
Contributor

@DharmitD DharmitD commented Jun 5, 2024

As part of migration from Prow to GH Action Workflows for KFP, we have a PR proposed to migrate presubmit backend tests to a GHA: kubeflow/pipelines#10871

This PR removes presubmit backend tests from the prow config in parallel.

Copy link
Contributor

Hi @DharmitD. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, DharmitD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d165017 into GoogleCloudPlatform:master Jun 6, 2024
5 of 6 checks passed
Copy link
Contributor

@DharmitD: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kubeflow-pipelines-presubmits.yaml using file prow/prowjobs/kubeflow/pipelines/kubeflow-pipelines-presubmits.yaml

In response to this:

As part of migration from Prow to GH Action Workflows for KFP, we have a PR proposed to migrate presubmit backend tests to a GHA: kubeflow/pipelines#10871

This PR removes presubmit backend tests from the prow config in parallel.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants