Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Migrate Backend tests to a GHA workflow #10871

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

DharmitD
Copy link
Contributor

@DharmitD DharmitD commented Jun 5, 2024

Description of your changes:
Resolves #10867

Converts the Prow backend test to a GH Action Workflow.

Here's a working GH Action run on my fork: https://github.com/DharmitD/data-science-pipelines-argo/actions/runs/9390063669

Checklist:

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In parallel to this PR, we need to remove kubeflow-pipeline-backend-test from GoogleCloudPlatform/oss-test-infra.

workflow_dispatch:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove these lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link

@DharmitD: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-e2e-test 89b7e61 link false /test kubeflow-pipeline-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@HumairAK
Copy link
Collaborator

HumairAK commented Jun 5, 2024

the tests in github actions look like they are running great:

Github workflow: https://github.com/kubeflow/pipelines/actions/runs/9390915591/job/25861839671?pr=10871
From Prow: https://oss.gprow.dev/view/gs/oss-prow/pr-logs/pull/kubeflow_pipelines/10871/kubeflow-pipeline-backend-test/1798454199197896704

/lgtm
/approve

@chensun

@rimolive
Copy link
Member

rimolive commented Jun 5, 2024

/approve

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thank you @DharmitD !

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, HumairAK, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8bcfb3d into kubeflow:master Jun 5, 2024
5 of 6 checks passed
@DharmitD
Copy link
Contributor Author

DharmitD commented Jun 5, 2024

In parallel to this PR, we need to remove kubeflow-pipeline-e2e-test from GoogleCloudPlatform/oss-test-infra.

Proposed a PR to remove this test from Prow: GoogleCloudPlatform/oss-test-infra#2296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Prow backend tests to GH Actions
5 participants