fix: update message reflecting functionality of error_log #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
|
I think this PR is failing due to php-tools issues with identity, trying to access private functions. |
glasnt
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
/gcbrun |
|
Looking into this more: it's not the deployment that's failing (as I previously guessed); it's the SystemTest that's failing, which uses See logs in #1943 where there's no changes, and the SystemTest fails. I'm not able to replicate this specific error locally (though I am getting a different error kokoro isn't getting) |
|
After updating php-tools for the linked PR (or alternative solution), tests for this should succeed. Keeping in draft until then. |
glasnt
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Ready for review ✨ |
iennae
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error_logflows through to Cloud logging, update message and comment.Fixes b/286058340