Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update message reflecting functionality of error_log #1936

Merged
merged 6 commits into from
May 16, 2024
Merged

fix: update message reflecting functionality of error_log #1936

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
060d9ae
fix: update message reflecting functionality of error_log
glasnt Nov 13, 2023
0d0b3b9
Merge branch 'main' into php/stderr
glasnt Dec 14, 2023
615ccea
fix: clarify
glasnt Dec 14, 2023
c47be5e
Merge branch 'main' into php/stderr
glasnt Jan 1, 2024
f1f97cb
Merge branch 'main' into php/stderr
glasnt Feb 23, 2024
1febcb8
Merge branch 'main' into php/stderr
glasnt May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions functions/helloworld_log/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ function helloLogging(ServerRequestInterface $request): string
'severity' => 'error'
]) . PHP_EOL);

// This doesn't log anything
error_log('error_log does not log in Cloud Functions!');
// This will log to standard error, which will appear in Cloud Logging
error_log('error_log logs in Cloud Functions!');

// This will log an error message and immediately terminate the function execution
// trigger_error('fatal errors are logged!');
Expand Down
Loading