-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jll version of git via Git package. #38
base: master
Are you sure you want to change the base?
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
72c7da6
to
7e1a06d
Compare
Possibly helpful here, Julia 1.7's changelog includes the following:
https://github.com/JuliaLang/julia/blob/v1.7.0-rc2/NEWS.md#package-manager While it wouldn't resolve a situation where a legitimate git client isn't installed, this might help with ssh authentication issues |
That's not really relevant here. LocalRegistry has never used |
e460411
to
7e1a06d
Compare
The MacOS build failures are discussed in JuliaVersionControl/Git.jl#40 (comment). |
7e1a06d
to
a09531e
Compare
32339ab
to
eeb0449
Compare
JuliaVersionControl/Git.jl#50 looks resolved now. Wondering if there are any updates planned on this PR? Thanks! |
Yes, the The drawback of the first option is that you always have to install the Implementing a package extension solves the drawback of the first option and keeps most of the advantages, except that now the user instructions become more complicated again, and you need to explain about installing the What may be nicer is to use the |
I'd vote for the second option. Out of curiosity, who uses |
I do, for one. At work all Julia packages have a CI job which runs only on merge to master, and calls LocalRegistry to register a new version. If the version number wasn't bumped, nothing happens, and if it was it's automatically registered. It's a good point that a package extension is a strict improvement over the current state, apart from additional instructions. A future change from a package extension to an unconditional dependency would still be a breaking change, but introducing a package extension isn't. |
8893836
to
92d2988
Compare
A drawback of a package extension is that it requires Julia 1.9 or later. However, I have implemented a way to make it possible to use the |
92d2988
to
30f6bc8
Compare
This PR removes the prerequisite to have a working
git
installed in yourPATH
and instead employs theGit
package to use a bundledgit
from thegit_jll
package.However, theThere are some workarounds possible, but for now, to try this out, do (in Pkg mode):Git
package requires a minimum Julia version of 1.6, which I don't want to impose on LocalRegistry just yet.This also adds an
external_git
custom_git
keyword argument, so by usingcustom_git = "git"
you can opt out of the bundledgit
and use your external one.Update:` Back on hold awaiting a solution to JuliaVersionControl/Git.jl#50.Resolved.Update March 2024: This is now implemented as a package extension. Mostly this means that you need to do
if you want to use the bundled
git
.