Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to calculate a UPS power value when none available - "UPS_POWER_FROM_LOAD_PERCENTAGE" #37

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

seb26
Copy link

@seb26 seb26 commented Sep 9, 2024

This works on my setup with a CyberPower OR600ERM1U UPS.

I'd love to run tests and poked around in manage/ but I couldn't figure out how to get that going - if you have any pointers I'd be happy to try again

My upsc output pretty much matches the CyberPower example in example-data/LIST-VAR-4.txt.

@seb26
Copy link
Author

seb26 commented Sep 11, 2024

This error fails on HEAD anyway:

error: use of `or_insert_with` to construct default value
   --> src/metrics.rs:531:39

This one is unique to my code in this PR:

error: this `if` statement can be collapsed
   --> src/nut_client.rs:136:5

I will try to address this.

@HON95
Copy link
Owner

HON95 commented Sep 26, 2024

Sorry for the slow response on this, I haven't forgotten it. And thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants