-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logic refax: new rules for the receiver buffer and TSBPD #2527
base: master
Are you sure you want to change the base?
Changes from 41 commits
496e6a7
03214ff
96e92dd
bdc6fff
a68d5cf
d2d1c90
89e927f
a56c84d
0168c5e
870509f
9f5174c
652e35d
6295cb9
36c1f67
1fbd754
478ca41
8335cbe
df46c57
1df7e40
0b515e8
f636ce7
ae914e5
519cb7e
4bb7b47
d179878
94fb676
8ad69ed
bbced79
5136ca2
f6e0271
072a8c4
1830e3a
283021e
b969a83
df237d6
d8f485a
d9f079a
ab469d6
a2b1b44
ff16e68
1f6ac3d
fa70fda
1bf93ff
f4f22ba
0a88fdf
74a27ed
cb00cce
5bc71e9
6bbd31d
5cba144
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1529,7 +1529,7 @@ if (ENABLE_UNITTESTS AND ENABLE_CXX11) | |
#set_tests_properties(test-srt PROPERTIES RUN_SERIAL TRUE) | ||
else() | ||
set_tests_properties(${tests_srt} PROPERTIES RUN_SERIAL TRUE) | ||
gtest_discover_tests(test-srt) | ||
#gtest_discover_tests(test-srt) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This excludes unit testing from GitHub CI jobs and makes the CodeCov gate fail. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is CodeCov using the only possible default configuration, or it can be done with enabled on demand? Here I can withdraw this change, but enabling these tests on demand (and not by default) is required. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, I fixed this by adding an option to disable test discovery. |
||
endif() | ||
|
||
enable_testing() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change of CMakeLists.txt can be moved to a separate PR. Plus corresponding changes to build options are needed: new build option
DISABLE_UNITTESTS_DISCOVERY