Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing set/getMisc(), docs, etc. #592

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

gregorgorjanc
Copy link
Member

This is to close #584

All checkc pass on my end so I think this can be merged in, but @janaobsteter have a look please.

@gregorgorjanc
Copy link
Member Author

I get this errors in the GitHub action

...
── Sitrep ──────────────────────────────────────────────────────────────────────
✖ Bootstrap 3 is deprecated; please switch to Bootstrap 5.
ℹ Learn more at
  <https://www.tidyverse.org/blog/2021/12/pkgdown-2-0-0/#bootstrap-5>.
✖ URLs not ok.
  In DESCRIPTION, URL is missing package url (http://www.simplybee.info/).
  See details in `vignette(pkgdown::metadata)`.
✔ Favicons ok.
✔ Open graph metadata ok.
✔ Articles metadata ok.
✖ Reference metadata not ok.
  In _pkgdown.yml, 3 topics missing from index: "getMisc", "mapLoci", and
  "setMisc".
  Either use `@keywords internal` to drop from index, or
...

but I don't see getMisc() anywhere in my codebase

grepall . getMisc
./.Rhistory
./NEWS.md
./docs/articles/A_Introduction_to_honeybee_biology.html
./docs/reference/addCastePop.html
./docs/reference/buildUp.html
./.git/logs/HEAD
./.git/logs/refs/heads/devel
./.git/COMMIT_EDITMSG
./.Rproj.user/2472D3BB/sources/session-5f57f60a/5D06C4D6-contents
./.Rproj.user/2472D3BB/sources/session-5f57f60a/7650117D-contents

grepall . setMisc
./NEWS.md
./.Rproj.user/2472D3BB/sources/session-5f57f60a/5D06C4D6-contents
./.Rproj.user/2472D3BB/sources/session-5f57f60a/7650117D-contents

Any clue what we have to do @janaobsteter ?

@gregorgorjanc gregorgorjanc changed the title Removing set/getMisc() fully #584 Removing set/getMisc(), docs, etc. Dec 15, 2024
@janaobsteter
Copy link
Collaborator

@gregorgorjanc , this is coming from pkgdown. I know there is a list of functions that it needs so I'm guessing those docs didn't get udpated. @LStrachan was handling this, not sure if we've ever documented how to update this.

@gregorgorjanc
Copy link
Member Author

gregorgorjanc commented Dec 16, 2024

I have now found these autogenerated files, but indeed don't have a clue how to use the pkgdown to generate them :( Aha, we have the process described in #497, but I now have to move to another task - enough of SIMplyBee for today I am afraid. Maybe we merge this PR in @janaobsteter and deal with the pkgdown issue later in #595?

Screenshot 2024-12-16 at 08 01 16

Copy link
Collaborator

@janaobsteter janaobsteter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregorgorjanc , I've just left three tiny comments and then we can merge

NEWS.md Show resolved Hide resolved
R/Functions_L0_auxilary.R Show resolved Hide resolved
vignettes/A_Honeybee_biology.Rmd Show resolved Hide resolved
@janaobsteter janaobsteter merged commit bfe06ec into HighlanderLab:devel Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants