Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jakarta el 8 #810

Closed
wants to merge 12 commits into from

Conversation

dmaidaniuk
Copy link

PR for issue #809

@dmaidaniuk dmaidaniuk marked this pull request as draft January 4, 2022 10:56
Copy link
Contributor

@jasmith-hs jasmith-hs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'd have a problem migrating off of the Odysseus implementation if it all works properly.
By the way, which repository did you get these new JUEL classes from, and is that repository still being maintained?

@dmaidaniuk
Copy link
Author

I don't think we'd have a problem migrating off of the Odysseus implementation if it all works properly. By the way, which repository did you get these new JUEL classes from, and is that repository still being maintained?

Well, I just built-in and upgrade Odysseus implementation according to EL 4 specification.

@dmaidaniuk
Copy link
Author

Hi @jasmith-hs
I created a new clean PR with required changes in Jinjava if used the forked JUEL library from my repo https://github.com/UkrSoftTech/juel/tree/jakarta-el-4. Unfortunately, the original repository https://github.com/beckchr/juel is not maintained anymore (the last commit was done 4 years ago). I made a PR to it too beckchr/juel#104. But I don't this that it will be merged in nearest future.

So, I'm clothing this PR in favor of a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants