Digital Twins page preview - trigger pipeline from client #891

VanessaScherma · 2024-08-26T10:59:03Z

Resolves issue #794. It includes a new link in ‘Workbench’ that gives access to the preview of the Digital Twins page. At the moment, only the ‘Execute’ tab has been developed.

…ture/distributed-demo

… feature/distributed-demo

…Scherma/DTaaS into gitlab

codeclimate · 2024-08-26T10:59:48Z

client/src/components/ExecuteDigitalTwin.tsx

+    .replace(/-/g, ' ')
+    .replace(/^./, (char) => char.toUpperCase());
+
+const ExecuteDigitalTwin: React.FC<{ name: string }> = (props) => {


Function ExecuteDigitalTwin has 177 lines of code (exceeds 25 allowed). Consider refactoring.

codeclimate · 2024-08-26T10:59:48Z

client/src/components/ExecuteDigitalTwin.tsx

+    .replace(/-/g, ' ')
+    .replace(/^./, (char) => char.toUpperCase());
+
+const ExecuteDigitalTwin: React.FC<{ name: string }> = (props) => {


Function ExecuteDigitalTwin has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.

codeclimate · 2024-08-26T10:59:48Z

client/src/route/digitaltwins/DigitalTwinsPreview.tsx

+import tabs from './DigitalTwinTabData';
+import ExecuteTab from '../../components/tab/ExecuteTab';
+
+function DTContent() {


Function DTContent has 38 lines of code (exceeds 25 allowed). Consider refactoring.

prasadtalasila

Partial code review done. Please remember to run yarn format and yarn syntax before committing your changes.

client/package.json

client/src/components/DigitalTwinCard.tsx

client/src/components/ExecuteDigitalTwin.tsx

client/src/components/tab/ExecuteTab.tsx

client/DEVELOPER.md

client/src/route/digitaltwins/DigitalTwinsPreview.tsx

client/src/components/DigitalTwinCard.tsx

prasadtalasila · 2024-08-26T18:18:03Z

@VanessaScherma Thanks for the PR. Please check the suggestions.

prasadtalasila

@VanessaScherma This round of comments completes the code review.

client/src/components/ExecuteDigitalTwin.tsx

prasadtalasila · 2024-08-28T13:20:22Z

client/src/components/ExecuteDigitalTwin.tsx

+
+const ExecuteDigitalTwin: React.FC<{ name: string }> = (props) => {
+  const [gitlabInstance, setGitlabInstance] = useState<GitlabInstance | null>(null);
+  const [digitalTwin, setDigitalTwin] = useState<DigitalTwin | null>(null);   


Please simplify these react component properties using react redux store. There are some good examples.

Should redux store only be used with gitlabInstance and digitalTwin properties?

Do not understand the question. Can you please elaborate?

In this case, the use of redux store does not seem to be usable, as the properties of this component are not global, but concern only one DT. Using redux store would result in continuous overwriting.

Is there a clean solution to this long list of component state?

client/src/util/gitlab.ts

client/src/route/digitaltwins/DigitalTwinsPreview.tsx

client/src/components/ExecuteDigitalTwin.tsx

prasadtalasila · 2024-08-29T11:13:18Z

@VanessaScherma
Please rebase to feature/distributed-demo branch.

… gitlab

VanessaScherma · 2024-09-05T13:48:27Z

@prasadtalasila
Have you created a pipeline trigger token in the project settings (CI/CD)?
(I actually have to add it to the necessary instructions)

… gitlab

prasadtalasila · 2024-09-05T13:40:31Z

client/src/components/asset/AddButton.tsx

please add only the asset components needed for your PR. For example, AddButton component is not required for now.

prasadtalasila · 2024-09-05T13:44:41Z

client/src/components/asset/AssetCard.tsx

+}
+
+function AssetCardExecute({ asset }: AssetCardExecuteProps) {
+  const [digitalTwin, setDigitalTwin] = useState<DigitalTwin>(


This probably does not belong to component state. Please rethink about this design choice.

VanessaScherma · 2024-09-05T14:18:14Z

@prasadtalasila
I am having some problems with rebasing gitlab to distributed-demo, can you help me please?

I used the command git rebase origin/feature/distributed-demo within the gitlab branch. However, after manually merging the conflicting files, it merged the gitlab branch into the gitlab branch, while distributed-demo is not modified in any way. Could you please tell me what the correct procedure is?

prasadtalasila · 2024-09-05T14:24:20Z

@prasadtalasila I am having some problems with rebasing gitlab to distributed-demo, can you help me please?

I used the command git rebase origin/feature/distributed-demo within the gitlab branch. However, after manually merging the conflicting files, it merged the gitlab branch into the gitlab branch, while distributed-demo is not modified in any way. Could you please tell me what the correct procedure is?

feature/distributed-demo doesn't get modified with the rebase. It is only the gitlab branch that gets rebased. The resolved merge conflicts might be showing as merges. If there is still conflicts, we can take them up tomorrow. You can also look at this tutorial.

VanessaScherma · 2024-09-05T14:41:28Z

@prasadtalasila I am having some problems with rebasing gitlab to distributed-demo, can you help me please?
I used the command git rebase origin/feature/distributed-demo within the gitlab branch. However, after manually merging the conflicting files, it merged the gitlab branch into the gitlab branch, while distributed-demo is not modified in any way. Could you please tell me what the correct procedure is?

feature/distributed-demo doesn't get modified with the rebase. It is only the gitlab branch that gets rebased. The resolved merge conflicts might be showing as merges. If there is still conflicts, we can take them up tomorrow. You can also look at this tutorial.

So the process would be: within the distributed-demo branch, do git rebase gitlab?

codeclimate · 2024-09-05T20:10:06Z

client/src/route/digitaltwins/ExecutionFunctions.ts

+  }
+};
+
+export const checkFirstPipelineStatus = async (


Similar blocks of code found in 4 locations. Consider refactoring.

codeclimate · 2024-09-05T20:10:06Z

client/src/route/digitaltwins/ExecutionFunctions.ts

+  }
+};
+
+const handlePipelineCompletion = async (


Similar blocks of code found in 4 locations. Consider refactoring.

codeclimate · 2024-09-05T20:10:07Z

client/src/route/digitaltwins/ExecutionFunctions.ts

+  );
+};
+
+const retryPipelineCheck = (


Similar blocks of code found in 4 locations. Consider refactoring.

codeclimate · 2024-09-05T20:10:07Z

client/src/route/digitaltwins/ExecutionFunctions.ts

+  );
+};
+
+export const checkSecondPipelineStatus = async (


Similar blocks of code found in 4 locations. Consider refactoring.

codeclimate · 2024-09-05T20:10:08Z

Code Climate has analyzed commit 94614ec and detected 8 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	4
Duplication	4

View more on Code Climate.

VanessaScherma · 2024-09-08T07:42:05Z

@prasadtalasila

I am working on the required tests and the only tests left are for the file ExecutionFunctions.ts. However, I am experiencing a problem that I cannot solve.
When I run the tests, I get this error about the strip-ansi library:

`Jest encountered an unexpected token

Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

By default "node_modules" folder is ignored by transformers.

Here's what you can do:
 • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
 • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
 • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
 • If you need a custom transformation specify a "transform" option in your config.
 • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

You'll find more details and examples of these config options in the docs:
https://jestjs.io/docs/configuration
For information about custom transformations, see:
https://jestjs.io/docs/code-transformation

Details:

/home/vanessa/Documenti/DtaaS/DTaaS/client/node_modules/strip-ansi/index.js:1
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){import ansiRegex from 'ansi-regex';
                                                                                  ^^^^^^

SyntaxError: Cannot use import statement outside a module

   6 | import DigitalTwin from 'util/gitlabDigitalTwin';
   7 | import { GitlabInstance } from 'util/gitlab';
>  8 | import stripAnsi from 'strip-ansi';
     | ^
   9 | import { JobLog } from '../../components/asset/StartStopButton';
  10 |
  11 | export const handleButtonClick = (

  at Runtime.createScriptFromCode (node_modules/jest-config/node_modules/jest-runtime/build/index.js:1505:14)
  at Object.require (src/route/digitaltwins/ExecutionFunctions.ts:8:1)
  at Object.<anonymous> (test/unit/routes/digitaltwins/ExecutionFunctions.test.ts:1:1)`

I even tried running an isolated test to verify that the library is loaded correctly, but the test fails and always returns the library index file, pointing out how the import is wrong.
I've tried changing the import method, to use require instead of import, but I can't get the tests to work. I did not want to edit the ts.config file so as not to compromise the other liberias. How can I solve this problem?

Thank you.

prasadtalasila · 2024-09-11T13:40:16Z

PR #903 includes the changes suggested here.

VanessaScherma and others added 25 commits May 2, 2024 13:42

configuration changes

5c78206

pre-commit-configuration

2d2b717

Merge branch 'INTO-CPS-Association:feature/distributed-demo' into fea…

3d6fb92

…ture/distributed-demo

Merge branch 'INTO-CPS-Association:feature/distributed-demo' into fea…

a3ff550

…ture/distributed-demo

class DigitalTwin added

4a9740b

configuration changes

e7f2964

Merge branch 'INTO-CPS-Association:feature/distributed-demo' into fea…

6beacfa

…ture/distributed-demo

Update gitlab.ts and gitlab.test.ts

663cc3d

Eslint fixes

c35450d

gitlab class updated

4f8e74a

Add DigitalTwinSubfolders

f0f1160

Fix

8536453

Add GitlabDriver and divide GitlabInstance and GitlabDigitalTwin

a86a47b

Change imports

56b412e

Adds config for managing gitlab code of client

c8dc464

Adds instructions for running gitlab code of client

8d20c28

Merge branch 'INTO-CPS-Association:feature/distributed-demo' into fea…

f61ea59

…ture/distributed-demo

Merge branch 'pr-830' of https://github.com/VanessaScherma/DTaaS into…

3f35520

… feature/distributed-demo

Comments resolved

7806eef

Refactor

ea3fd03

Refactor

41cd332

Temporary update

cb8c5e8

Merge branch 'feature/distributed-demo' of https://github.com/Vanessa…

3a70879

…Scherma/DTaaS into gitlab

Change GitlabInstance constructor parameters

d54bbb8

Digital Twins page preview completed

19b893f

codeclimate bot reviewed Aug 26, 2024

View reviewed changes

prasadtalasila reviewed Aug 26, 2024

View reviewed changes

prasadtalasila reviewed Aug 28, 2024

View reviewed changes

VanessaScherma added 9 commits September 5, 2024 15:25

Digital Twins page preview completed

15bdaf6

Code review fixes

0809a1c

Convert DTContent into class

60cd817

Add class for DigitalTwinsPreview

84f8901

Add documentation to DEVELOPER.md

7535eb4

Use Asset components (graphical adaptation)

fe2563b

Use asset components

06176f6

Merge branch 'gitlab' of https://github.com/VanessaScherma/DTaaS into…

2f7ce42

… gitlab

Temporary update

2f65511

VanessaScherma added 8 commits September 5, 2024 15:52

Digital Twins page preview completed

d1f1b87

Code review fixes

5168797

Convert DTContent into class

488ca46

Add class for DigitalTwinsPreview

f044b6c

Add documentation to DEVELOPER.md

a518099

Use Asset components (graphical adaptation)

99b4ff3

Use asset components

e80192c

Merge branch 'gitlab' of https://github.com/VanessaScherma/DTaaS into…

33c9351

… gitlab

prasadtalasila reviewed Sep 5, 2024

View reviewed changes

VanessaScherma added 2 commits September 5, 2024 19:04

use redux to store digital twin

5a1eae8

Fix codeclimate issues

94614ec

codeclimate bot reviewed Sep 5, 2024

View reviewed changes

VanessaScherma mentioned this pull request Sep 10, 2024

Add 'Execute' tab to Digital Twins page preview #903

Merged

prasadtalasila closed this Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Digital Twins page preview - trigger pipeline from client #891

Digital Twins page preview - trigger pipeline from client #891

VanessaScherma commented Aug 26, 2024

codeclimate bot Aug 26, 2024

codeclimate bot Aug 26, 2024

codeclimate bot Aug 26, 2024

prasadtalasila left a comment

prasadtalasila commented Aug 26, 2024

prasadtalasila left a comment

prasadtalasila Aug 28, 2024

VanessaScherma Sep 1, 2024

prasadtalasila Sep 1, 2024

VanessaScherma Sep 2, 2024

prasadtalasila Sep 2, 2024

prasadtalasila commented Aug 29, 2024

VanessaScherma commented Sep 5, 2024

prasadtalasila Sep 5, 2024

prasadtalasila Sep 5, 2024

VanessaScherma commented Sep 5, 2024

prasadtalasila commented Sep 5, 2024

VanessaScherma commented Sep 5, 2024

codeclimate bot Sep 5, 2024

codeclimate bot Sep 5, 2024

codeclimate bot Sep 5, 2024

codeclimate bot Sep 5, 2024

codeclimate bot commented Sep 5, 2024

VanessaScherma commented Sep 8, 2024

prasadtalasila commented Sep 11, 2024

Digital Twins page preview - trigger pipeline from client #891

Digital Twins page preview - trigger pipeline from client #891

Conversation

VanessaScherma commented Aug 26, 2024

codeclimate bot Aug 26, 2024

Choose a reason for hiding this comment

codeclimate bot Aug 26, 2024

Choose a reason for hiding this comment

codeclimate bot Aug 26, 2024

Choose a reason for hiding this comment

prasadtalasila left a comment

Choose a reason for hiding this comment

prasadtalasila commented Aug 26, 2024

prasadtalasila left a comment

Choose a reason for hiding this comment

prasadtalasila Aug 28, 2024

Choose a reason for hiding this comment

VanessaScherma Sep 1, 2024

Choose a reason for hiding this comment

prasadtalasila Sep 1, 2024

Choose a reason for hiding this comment

VanessaScherma Sep 2, 2024

Choose a reason for hiding this comment

prasadtalasila Sep 2, 2024

Choose a reason for hiding this comment

prasadtalasila commented Aug 29, 2024

VanessaScherma commented Sep 5, 2024

prasadtalasila Sep 5, 2024

Choose a reason for hiding this comment

prasadtalasila Sep 5, 2024

Choose a reason for hiding this comment

VanessaScherma commented Sep 5, 2024

prasadtalasila commented Sep 5, 2024

VanessaScherma commented Sep 5, 2024

codeclimate bot Sep 5, 2024

Choose a reason for hiding this comment

codeclimate bot Sep 5, 2024

Choose a reason for hiding this comment

codeclimate bot Sep 5, 2024

Choose a reason for hiding this comment

codeclimate bot Sep 5, 2024

Choose a reason for hiding this comment

codeclimate bot commented Sep 5, 2024

VanessaScherma commented Sep 8, 2024

prasadtalasila commented Sep 11, 2024