Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Execute' tab to Digital Twins page preview #903

Open
wants to merge 12 commits into
base: feature/distributed-demo
Choose a base branch
from

Conversation

VanessaScherma
Copy link
Contributor

It replaces PR #891. It completes the Execute tab present on the Digital twins page preview, which is accessible from the appropriate link within the Workbench. Only some unit tests are still incomplete due to the library import error.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 6946 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 7108 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 7093 lines exceeds the maximum allowed for the inline comments feature.

@prasadtalasila
Copy link
Contributor

@VanessaScherma suggestions to improve the PR:

  1. Remove job number from status messages. Only store the latest log in the browser cache.
  2. Write about the need to add "pipeline trigger token" in GITLAB-RUNNER.md
  3. Do not "busy wait" for job logs. Have a 5 second wait between sequential log requests.
  4. If the job execution takes too long (how long?), the DT execution "Start" button is active forever.

Also replace text at the top of "Execute" Tab with the following

"This page demonstrates integration of DTaaS with gitlab CI/CD workflows. The feature is experimental and requires certain gitlab setup in order for it to work."

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 7103 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 7245 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 7817 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented Sep 14, 2024

Code Climate has analyzed commit b56730b and detected 12 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 10
Bug Risk 1
Style 1

View more on Code Climate.

@prasadtalasila prasadtalasila added this to the Release v0.6.0 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants