-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Execute' tab to Digital Twins page preview #903
base: feature/distributed-demo
Are you sure you want to change the base?
Add 'Execute' tab to Digital Twins page preview #903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 6946 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 7108 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 7093 lines exceeds the maximum allowed for the inline comments feature.
@VanessaScherma suggestions to improve the PR:
Also replace text at the top of "Execute" Tab with the following "This page demonstrates integration of DTaaS with gitlab CI/CD workflows. The feature is experimental and requires certain gitlab setup in order for it to work." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 7103 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 7245 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 7817 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit b56730b and detected 12 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
It replaces PR #891. It completes the Execute tab present on the Digital twins page preview, which is accessible from the appropriate link within the Workbench. Only some unit tests are still incomplete due to the library import error.