Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only publish docker image if version is not yet published #926

Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ on:
registry:
required: false
type: string
default: 'ghcr.io'
default: "ghcr.io"
image-name:
required: true
type: string
version:
required: true
type: string
default: 'latest'
default: "latest"
dockerfile:
required: true
type: string
Expand All @@ -23,8 +23,8 @@ jobs:
runs-on: ubuntu-latest

permissions:
contents: read
packages: write
contents: read
packages: write

steps:
- name: Checkout Repository
Expand All @@ -37,7 +37,19 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Check if version exists
id: check_version
run: |
if docker manifest inspect ${{ inputs.registry }}/${{ inputs.image-name }}:${{ inputs.version }} > /dev/null 2>&1; then
echo "Version ${{ inputs.version }} already exists."
echo "exists=true" >> $GITHUB_ENV
else
echo "Version ${{ inputs.version }} does not exist."
echo "exists=false" >> $GITHUB_ENV
fi

- name: Build and push Docker image
if: env.exists == 'false'
uses: docker/build-push-action@v5
with:
context: .
Expand Down
10 changes: 5 additions & 5 deletions client/config/dev.js
nichlaes marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
if (typeof window !== 'undefined') {
window.env = {
REACT_APP_ENVIRONMENT: 'dev',
REACT_APP_URL: 'http://localhost/',
REACT_APP_URL: 'http://localhost:4000/',
REACT_APP_URL_BASENAME: '',
REACT_APP_URL_DTLINK: '/lab',
REACT_APP_URL_LIBLINK: '',
Expand All @@ -11,9 +11,9 @@ if (typeof window !== 'undefined') {
REACT_APP_WORKBENCHLINK_JUPYTERNOTEBOOK: '',

REACT_APP_CLIENT_ID: '1be55736756190b3ace4c2c4fb19bde386d1dcc748d20b47ea8cfb5935b8446c',
REACT_APP_AUTH_AUTHORITY: 'https://gitlab.foo.com/',
REACT_APP_REDIRECT_URI: 'http://localhost/Library',
REACT_APP_LOGOUT_REDIRECT_URI: 'http://localhost/',
REACT_APP_AUTH_AUTHORITY: 'https://gitlab.com/',
REACT_APP_REDIRECT_URI: 'http://localhost:4000/Library',
REACT_APP_LOGOUT_REDIRECT_URI: 'http://localhost:4000/',
REACT_APP_GITLAB_SCOPES: 'openid profile read_user read_repository api',
};
};
};
8 changes: 4 additions & 4 deletions servers/lib/DEVELOPER.md
nichlaes marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ it is required to manually run `yarn test:http` with `LOCAL_PATH` both as an
absolute path and local path. For example, the manual tests
need to be done with the following `LOCAL_PATH` values.

| OS | Absolute Path | Relative Path |
| ------- | ----------------------------- | ------------- |
| Windows | C:\DTaaS\files | ..\..\files |
| Linux | /Users/<Username>/DTaaS/files | ../../files |
| OS | Absolute Path | Relative Path |
| ------- | ------------------------------- | ------------- |
| Windows | C:\DTaaS\files | ..\..\files |
| Linux | /Users/\<Username\>/DTaaS/files | ../../files |

### PM2

Expand Down
Loading