[이주영] 1차 과제 제출

Java/src/main/java/com/gildedrose/GildedRose.java

@@ -1,62 +1,21 @@
 package com.gildedrose;
 
+import com.gildedrose.Update.UpdateLogic;
+import com.gildedrose.Update.UpdateLogicFactory;
+
 class GildedRose {
     Item[] items;
+    UpdateLogicFactory updateLogicFactory;
 
     public GildedRose(Item[] items) {
         this.items = items;
+        updateLogicFactory = new UpdateLogicFactory();
     }
 
     public void updateQuality() {
-        for (int i = 0; i < items.length; i++) {
-            if (!items[i].name.equals("Aged Brie")
-                    && !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
-                if (items[i].quality > 0) {
-                    if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
-                        items[i].quality = items[i].quality - 1;
-                    }
-                }
-            } else {
-                if (items[i].quality < 50) {
-                    items[i].quality = items[i].quality + 1;
-
-                    if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
-                        if (items[i].sellIn < 11) {
-                            if (items[i].quality < 50) {
-                                items[i].quality = items[i].quality + 1;
-                            }
-                        }
-
-                        if (items[i].sellIn < 6) {
-                            if (items[i].quality < 50) {
-                                items[i].quality = items[i].quality + 1;
-                            }
-                        }
-                    }
-                }
-            }
-
-            if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
-                items[i].sellIn = items[i].sellIn - 1;
-            }
-
-            if (items[i].sellIn < 0) {
-                if (!items[i].name.equals("Aged Brie")) {
-                    if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
-                        if (items[i].quality > 0) {
-                            if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
-                                items[i].quality = items[i].quality - 1;
-                            }
-                        }
-                    } else {
-                        items[i].quality = items[i].quality - items[i].quality;
-                    }
-                } else {
-                    if (items[i].quality < 50) {
-                        items[i].quality = items[i].quality + 1;
-                    }
-                }
-            }
+        for (Item item : items) {
+            UpdateLogic updateLogic = updateLogicFactory.getUpdateLogic(item);
+            updateLogic.update(item);
         }
     }
 }

Java/src/main/java/com/gildedrose/Update/UpdateAgedBrieLogic.java

@@ -0,0 +1,22 @@
+package com.gildedrose.Update;
+
+import com.gildedrose.Item;
+
+public class UpdateAgedBrieLogic implements UpdateLogic {
+
+    @Override
+    public void update(Item item) {
+
+        if (item.quality < 50) {
+            item.quality++;
+        }
+
+        // 기존 시스템도 quality값 50 미만인지 검사 후 quality++ -> sellIn-- -> 판매 기한 지났는지 검사 후 quality++이므로 해당 구조 유지
+        item.sellIn--;
+
+        if (item.sellIn < 0 && item.quality < 50) {
+            item.quality++;
+        }
+
+    }
+}

Java/src/main/java/com/gildedrose/Update/UpdateBackstagePassesLogic.java

@@ -0,0 +1,26 @@
+package com.gildedrose.Update;
+
+import com.gildedrose.Item;
+
+public class UpdateBackstagePassesLogic implements UpdateLogic {
+
+    @Override
+    public void update(Item item) {
+
+        if (item.quality < 50) {
+            item.quality++;
+        }
+        if (item.sellIn <= 10 && item.quality < 50) {
+            item.quality++;
+        }
+        if (item.sellIn <= 5 && item.quality < 50) {
+            item.quality++;
+        }
+
+        item.sellIn--;
+
+        if (item.sellIn < 0) {
+            item.quality = 0;
+        }
+    }
+}

Java/src/main/java/com/gildedrose/Update/UpdateConjuredItemLogic.java

@@ -0,0 +1,26 @@
+package com.gildedrose.Update;
+
+import com.gildedrose.Item;
+
+public class UpdateConjuredItemLogic implements UpdateLogic {
+
+    @Override
+    public void update(Item item) {
+
+        if (item.quality > 0) {
+            item.quality -= 2;
+        }
+
+        item.sellIn--;
+
+        if (item.sellIn < 0 && item.quality > 0) {
+            item.quality -= 2;
+        }
+
+        if (item.quality < 0) {
+            // quality가 음수가 될수도 있으므로
+            // sellIn > 0, quality = 1인 경우, sellIn < 0, quality = 3인 경우 해당
+            item.quality = 0;
+        }
+    }
+}

Java/src/main/java/com/gildedrose/Update/UpdateDefaultItemLogic.java

@@ -0,0 +1,19 @@
+package com.gildedrose.Update;
+
+import com.gildedrose.Item;
+
+public class UpdateDefaultItemLogic implements UpdateLogic {
+
+    @Override
+    public void update(Item item) {
+        if (item.quality > 0) {
+            item.quality--;
+        }
+
+        item.sellIn--;
+
+        if (item.sellIn < 0 && item.quality > 0) {
+            item.quality--;
+        }
+    }
+}

Java/src/main/java/com/gildedrose/Update/UpdateLogic.java

@@ -0,0 +1,7 @@
+package com.gildedrose.Update;
+
+import com.gildedrose.Item;
+
+public interface UpdateLogic {
+    void update(Item item);
+}

Java/src/main/java/com/gildedrose/Update/UpdateLogicFactory.java

@@ -0,0 +1,23 @@
+package com.gildedrose.Update;
+
+import com.gildedrose.Item;
+
+public class UpdateLogicFactory {
+    public static UpdateLogic getUpdateLogic(Item item) {
+        if (item.name.contains("Conjured")) {
+            // Conjured 아이템인 경우 switch문에서 판별 불가능하므로 별도 처리
+            return new UpdateConjuredItemLogic();
+        }
+
+        switch (item.name) {
+            case "Aged Brie":
+                return new UpdateAgedBrieLogic();
+            case "Backstage passes to a TAFKAL80ETC concert":
+                return new UpdateBackstagePassesLogic();
+            case "Sulfuras, Hand of Ragnaros":
+                return new UpdateSulfurasLogic();
+            default:
+                return new UpdateDefaultItemLogic();
+        }
+    }
+}

Java/src/main/java/com/gildedrose/Update/UpdateSulfurasLogic.java

@@ -0,0 +1,11 @@
+package com.gildedrose.Update;
+
+import com.gildedrose.Item;
+
+public class UpdateSulfurasLogic implements UpdateLogic {
+
+    @Override
+    public void update(Item item) {
+
+    }
+}

Java/src/test/java/com/gildedrose/TexttestFixture.java

@@ -5,16 +5,15 @@ public static void main(String[] args) {
         System.out.println("OMGHAI!");
 
         Item[] items = new Item[] {
-                new Item("+5 Dexterity Vest", 10, 20), //
-                new Item("Aged Brie", 2, 0), //
-                new Item("Elixir of the Mongoose", 5, 7), //
-                new Item("Sulfuras, Hand of Ragnaros", 0, 80), //
-                new Item("Sulfuras, Hand of Ragnaros", -1, 80),
-                new Item("Backstage passes to a TAFKAL80ETC concert", 15, 20),
-                new Item("Backstage passes to a TAFKAL80ETC concert", 10, 49),
-                new Item("Backstage passes to a TAFKAL80ETC concert", 5, 49),
-                // this conjured item does not work properly yet
-                new Item("Conjured Mana Cake", 3, 6) };
+            new Item("+5 Dexterity Vest", 10, 20), //
+            new Item("Aged Brie", 2, 0), //
+            new Item("Elixir of the Mongoose", 5, 7), //
+            new Item("Sulfuras, Hand of Ragnaros", 0, 80), //
+            new Item("Sulfuras, Hand of Ragnaros", -1, 80),
+            new Item("Backstage passes to a TAFKAL80ETC concert", 15, 20),
+            new Item("Backstage passes to a TAFKAL80ETC concert", 10, 49),
+            new Item("Backstage passes to a TAFKAL80ETC concert", 5, 49),
+            new Item("Conjured Mana Cake", 3, 6)};
 
         GildedRose app = new GildedRose(items);