I4 add units, I1 remove duplicate collection #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labradford
changed the title
dlim87
reviewed
Mar 17, 2020
| @@ -97,7 +97,7 @@ class CatalogController < ApplicationController | |||
| config.add_facet_field 'geogname_sim', label: 'Place', limit: 10 | |||
| config.add_facet_field 'places_ssim', label: 'Places', show: false | |||
| config.add_facet_field 'access_subjects_ssim', label: 'Subject', limit: 10 | |||
|
|
|||
| config.add_facet_field 'campus_unit_sim', label: 'Campus', helper_method: :render_campus_facet | |||
There was a problem hiding this comment.
Suggested change
| config.add_facet_field 'campus_unit_sim', label: 'Campus', helper_method: :render_campus_facet | |
| config.add_facet_field 'campus_unit_sim', label: 'Campus', helper_method: :render_campus_facet | |
can we add the linebreak back to make the separation clearer?
There was a problem hiding this comment.
I don't understand this suggestion
There was a problem hiding this comment.
You replaced the one line of whitespace between that set of code and the next one
There was a problem hiding this comment.
I.e. it went from
config.add_facet_field 'access_subjects_ssim', label: 'Subject', limit: 10
# Have BL send all facet field names to Solr, which has been the default
to
config.add_facet_field 'access_subjects_ssim', label: 'Subject', limit: 10
config.add_facet_field 'campus_unit_sim', label: 'Campus', helper_method: :render_campus_facet
# Have BL send all facet field names to Solr, which has been the default
dlim87
reviewed
Mar 17, 2020
orangewolf
approved these changes
Mar 20, 2020
This was referenced Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues:
#1 and #4
Issue 1: Child components with the attribute level="collection" are causing duplicate indexing issues. Added code to indexer to ignore child attributes that have the level="collection" attribute. It is not believed that there are any child components that will need to be indexed as collections. We may need to revisit this at a later time if we find that this is not the case.
Issue 4: IU would like to add the Campus level to indexing. This PR included an EAD with the attribute "mainagencycode" and includes modifications to the ead2_config file to add Campus to the index. The campus is now added to the show page tabs for overview and access. It has also been added as a search facet
Screenshots:
Duplicate Collections removed:
Indexing Campus:
Access Tab:
Facets:
Breadcrumbs: