Port Customer DAO to use PDO #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be reused by other DAOs. The class name for PDO::FETCH_CLASS is now passed as a parameter.
The declaration in CustomerDAO was shadowed by the one in PostgreSQLCustomerDAO, it was actually invalid because it was declared "protected", which didn't allow the DAOFactory to instantiate it.
The query for getAll when $active is set was incorrect, so it has been changed. The front end is not using it, but it can be tested calling web/services/getUserCustomersService.php?active=true CustomerVO property names changed for PDO::FETCH_CLASS to work.
jaragunde
force-pushed
the
pdo-customer
branch
from
2cc39b0
to
eb6eea7
Compare
anarute
approved these changes
Jan 17, 2022
The query was incorrect and we hadn't noticed because it's not currently used by our front end. It can be tested calling web/services/getUserCustomersService.php?uid=admin&active=true
It was only used from SectorDAO::GetCustomers, which was in turn unused.
We also remove unnecessary checks for the customer id in update and delete operations.
Fixes: * Undefined index: sid, uid, active, login, order * Undefined variable: string
jaragunde
force-pushed
the
pdo-customer
branch
from
eb6eea7
to
4839173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does some refactoring to reuse the
runSelectQuery()function and ports another DAO,CustomerDAO, to use the PDO API. Part of #513.Includes a patch for #431. Also removes unused code.