-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Customer DAO to use PDO #551
Commits on Jan 12, 2022
-
Move runSelectQuery() up to BaseDAO.
It will be reused by other DAOs. The class name for PDO::FETCH_CLASS is now passed as a parameter.
Configuration menu - View commit details
-
Copy full SHA for df4e6f2 - Browse repository at this point
Copy the full SHA df4e6f2View commit details -
Remove redundant CustomerDAO constructor declaration.
The declaration in CustomerDAO was shadowed by the one in PostgreSQLCustomerDAO, it was actually invalid because it was declared "protected", which didn't allow the DAOFactory to instantiate it.
Configuration menu - View commit details
-
Copy full SHA for 5bd78ab - Browse repository at this point
Copy the full SHA 5bd78abView commit details -
Migrate CustomerDAO::getById and getAll to PDO.
The query for getAll when $active is set was incorrect, so it has been changed. The front end is not using it, but it can be tested calling web/services/getUserCustomersService.php?active=true CustomerVO property names changed for PDO::FETCH_CLASS to work.
Configuration menu - View commit details
-
Copy full SHA for 6141862 - Browse repository at this point
Copy the full SHA 6141862View commit details
Commits on Jan 25, 2022
-
Migrate CustomerDAO::getByProjectUserLogin to PDO.
The query was incorrect and we hadn't noticed because it's not currently used by our front end. It can be tested calling web/services/getUserCustomersService.php?uid=admin&active=true
Configuration menu - View commit details
-
Copy full SHA for 011987c - Browse repository at this point
Copy the full SHA 011987cView commit details -
Remove unused CustomerDAO::getBySectorId and related code.
It was only used from SectorDAO::GetCustomers, which was in turn unused.
Configuration menu - View commit details
-
Copy full SHA for 0424e4b - Browse repository at this point
Copy the full SHA 0424e4bView commit details -
Migrate CustomerDAO create/update/delete operations to PDO.
We also remove unnecessary checks for the customer id in update and delete operations.
Configuration menu - View commit details
-
Copy full SHA for 04bd184 - Browse repository at this point
Copy the full SHA 04bd184View commit details -
[#431] Fix PHP warnings in customer management page.
Fixes: * Undefined index: sid, uid, active, login, order * Undefined variable: string
Configuration menu - View commit details
-
Copy full SHA for 06a1e57 - Browse repository at this point
Copy the full SHA 06a1e57View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4f3dbe - Browse repository at this point
Copy the full SHA e4f3dbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4839173 - Browse repository at this point
Copy the full SHA 4839173View commit details