Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow of when there are more opal columns in the datahub than in pre-set data #102

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Allow of when there are more opal columns in the datahub than in pre-set data #102

merged 4 commits into from
Dec 1, 2023

Conversation

AdrianDAlessandro
Copy link
Collaborator

@AdrianDAlessandro AdrianDAlessandro commented Dec 1, 2023 •
edited
Loading

Description

Allow for the current case when the datahub has more columns than the pre-set data

This is a temporary bugfix for while there are more columns in the datahub than the pre-set data until the new data is available in #100

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (python -m pytest)
  • Pre-commit hooks run successfully (pre-commit run --all-files)

@AdrianDAlessandro AdrianDAlessandro added the bug Something isn't working label Dec 1, 2023
tsmbland
tsmbland approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@tsmbland tsmbland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AdrianDAlessandro
Copy link
Collaborator Author

Sorry, I realised I should probably do this with the pre-set data also. Can you check it again?

tsmbland
tsmbland approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@tsmbland tsmbland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok makes sense

@AdrianDAlessandro AdrianDAlessandro mentioned this pull request Dec 1, 2023
Open
@AdrianDAlessandro AdrianDAlessandro merged commit 69b3801 into main Dec 1, 2023
4 checks passed
@AdrianDAlessandro AdrianDAlessandro deleted the column-mismatch branch December 1, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmbland tsmbland tsmbland approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdrianDAlessandro @tsmbland