Email as permission #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lugrim
added a commit
that referenced
this pull request
Oct 13, 2023
- Added a few tests - Made them all pass - `test_permission_is_removed_when_changing_email` will be fixed when #65 will me fixed and merged
Lymkwi
requested changes
Oct 13, 2023
Lugrim
force-pushed
the
email-as-permission
branch
2 times, most recently
from
2cd791c to
43f5347
Compare
Lymkwi
requested changes
Oct 14, 2023
Lugrim
force-pushed
the
email-as-permission
branch
from
987ec3b to
59c7a2b
Compare
Lugrim
added a commit
that referenced
this pull request
Oct 14, 2023
- Added a few tests - Made them all pass - `test_permission_is_removed_when_changing_email` will be fixed when #65 will me fixed and merged
Lugrim
added a commit
that referenced
this pull request
Oct 14, 2023
- Added a few tests - Made them all pass - `test_permission_is_removed_when_changing_email` will be fixed when #65 will me fixed and merged
Lugrim
force-pushed
the
email-as-permission
branch
from
59c7a2b to
3dcc2e1
Compare
Lymkwi
approved these changes
Oct 14, 2023
Lugrim
force-pushed
the
email-as-permission
branch
from
3dcc2e1 to
1959d7a
Compare
This is the dirtiest solution ever, please save me
- Please make it stop, I can't bare DRF anymore
- Fixed the language of a string - Check that an user is not anonymous (not logged in)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that an user has activated their email is now managed as a permission