-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly check for properties in thaw/snow #2976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
Nov 3, 2024
- fixes Out of bounds exception? #2963
2 tasks
dordsor21
changed the title
Make property changes more robust
fix: correctly check for properties in thaw/snow
Nov 3, 2024
PierreSchwang
approved these changes
Nov 3, 2024
worldedit-core/src/main/java/com/sk89q/worldedit/function/block/SnowSimulator.java
Outdated
Show resolved
Hide resolved
Please take a moment and address the merge conflicts of your pull request. Thanks! |
dordsor21
force-pushed
the
fix/further-property-checks
branch
from
November 4, 2024 17:42
5558611
to
2c1a212
Compare
SirYwell
reviewed
Nov 14, 2024
worldedit-core/src/main/java/com/sk89q/worldedit/world/block/BlockType.java
Outdated
Show resolved
Hide resolved
dordsor21
force-pushed
the
fix/further-property-checks
branch
from
November 16, 2024 11:04
916e46d
to
013982d
Compare
SirYwell
approved these changes
Nov 18, 2024
NotMyFault
approved these changes
Nov 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.