Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve certificate performance #4643

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Improve certificate performance #4643

merged 3 commits into from
Sep 24, 2024

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Sep 23, 2024 •
edited
Loading

Description

This PR improves certificate performance and makes it more clear what is going on.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins requested a review from a team as a code owner September 23, 2024 20:36
@lehins lehins mentioned this pull request Sep 23, 2024
Merged
9 tasks
@lehins lehins force-pushed the lehins/improve-certificate-performance branch from fed0a2d to 8f206fa Compare September 23, 2024 20:53
TimSheard
TimSheard approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments to add to the code.

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Deleg.hs Show resolved Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/Rules/Deleg.hs Show resolved Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/UMap.hs Show resolved Hide resolved
teodanciu
teodanciu approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we could later add deleteStakingCredential and extractStakingCredential to cardano-ledger-core CHANGELOG.

@lehins lehins merged commit 389f6c0 into master Sep 24, 2024
151 of 154 checks passed
@lehins lehins deleted the lehins/improve-certificate-performance branch September 24, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodanciu teodanciu teodanciu approved these changes

@TimSheard TimSheard TimSheard approved these changes

@Lucsanszky Lucsanszky Lucsanszky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lehins @teodanciu @TimSheard @Lucsanszky