G2 lib with GNU compiler fix #476
Conversation
| @@ -59,6 +59,12 @@ def cmake_args(self): | |||
|
|
|||
| return args | |||
|
|
|||
| # GNU compiler is complaining if not using -fno-range-check argument | |||
There was a problem hiding this comment.
Is it safe to apply this to newer gfortran versions, too? I know we need it for 9.2.0 (hera, jet) and 9.4.0 (containers), but I am not sure it's needed for gfortran-10+
There was a problem hiding this comment.
Is it safe to apply this to newer gfortran versions, too? I know we need it for 9.2.0 (hera, jet) and 9.4.0 (containers), but I am not sure it's needed for gfortran-10+
Right, I don't know if this will affect any other machine as well. But actually, this argument is benign, it should work for any machine/compiler version. Unless we see the problem, I'd leave it as is.
|
@RatkoVasic-NOAA Style tests fail, see https://github.com/JCSDA/spack/actions/runs/10690265381/job/29634235299?pr=476 I also changed the base branch to release/1.8.0 |
There was a problem hiding this comment.
@AlexanderRichert-NOAA Are you ok with a blanket -fno-range-check option for all versions of gfortran, or would you like to see it narrowed down to just version 9.x.y?
Something along the lines of:
To keep in mind and change here in any case: We need to check if the Fortran compiler contains gfortran (and not endswith gfortran, sometimes it ends with gfortran-9 for example). This will still not cover Crays that use the Cray compiler wrappers (ftn), but we don't have any Crays that use gfortran@9.
|
Superseded by #477 |
Fixed G2 lib compilation failures with GNU compiler on Hera machine ([email protected]).
Fixing issue: #475