Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/1.8.0: bug fix for compiling [email protected] with gfortran < 10 #477

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Sep 5, 2024

For release/1.8.0: This PR is based on #476 (credits @RatkoVasic-NOAA), but narrowed down to one specific version of g2 and for gfortran earlier than version 10.

Corresponding spack-stack PR: JCSDA/spack-stack#1287

@climbfuji climbfuji changed the title WIP - Bugfix/g2 gnu fix dom release/1.8.0: bug fix for compiling [email protected] with gfortran < 10 Sep 5, 2024
@climbfuji climbfuji self-assigned this Sep 5, 2024
@climbfuji climbfuji marked this pull request as ready for review September 5, 2024 17:31
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Is the idea of not using if self.spec.satisfies("%gcc@:...") to handle the case where we're using gfortran with clang or something like that?

@climbfuji
Copy link
Collaborator Author

Cool. Is the idea of not using if self.spec.satisfies("%gcc@:...") to handle the case where we're using gfortran with clang or something like that?

Exactly. macOS uses apple-clang + gfortran, for example.

Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@climbfuji climbfuji merged commit 78e0c1d into JCSDA:release/1.8.0 Sep 5, 2024
15 checks passed
@climbfuji climbfuji deleted the bugfix/g2_gnu_fix_dom branch September 5, 2024 20:50
climbfuji added a commit to JCSDA/spack-stack that referenced this pull request Sep 5, 2024
…pack package, remove from container configs (#1287)

For release/1.8.0: Update submodule pointer for spack for the changes in JCSDA/spack#477. Remove g2 compiler flags in container configs, since these are now in the g2 package itself.

Also include a bug fix to adjust the py-numpy version to match what is in configs/common/packages.yaml since yesterday (1.23.5).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants