Add backend firebase function and fix search page parsing #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackNUMBER
reviewed
Jan 9, 2024
| let name = element.querySelectorAll('.dl-search-result-name')[0].textContent; | ||
| const name = element.querySelector('[data-test="dl-search-result-name"]').textContent; | ||
|
|
||
| const addressDiv = element.querySelector('.ml-96'); |
There was a problem hiding this comment.
Seems not durable (depending of UI kit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3 #1
I did not try to piggyback on the Google Maps API initialized by the map view. The map is not on by default anymore and it looks like they added a few restrictions. I did not try much to be honest so there might be a way to hack it.
Note: it's not ideal to set up a wrapper around Google. To mitigate potential costs we could set up a simple caching mechanism. There are about 200k doctors in France and the Google API is around $17 for 100,000 calls.