Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backend firebase function and fix search page parsing #4

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .firebaserc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"projects": {
"default": "doctolib-reviews-4807a"
}
}
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
releases/
assets/
ressources/
*.DS_Store
18 changes: 18 additions & 0 deletions firebase.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"functions": [
{
"source": "functions",
"codebase": "default",
"ignore": [
"node_modules",
".git",
"firebase-debug.log",
"firebase-debug.*.log"
],
"predeploy": [
"npm --prefix \"$RESOURCE_DIR\" run lint",
"npm --prefix \"$RESOURCE_DIR\" run build"
]
}
]
}
32 changes: 32 additions & 0 deletions functions/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
module.exports = {
root: true,
env: {
es6: true,
node: true,
},
extends: [
"eslint:recommended",
"plugin:import/errors",
"plugin:import/warnings",
"plugin:import/typescript",
"google",
"plugin:@typescript-eslint/recommended",
],
parser: "@typescript-eslint/parser",
parserOptions: {
project: ["tsconfig.json", "tsconfig.dev.json"],
sourceType: "module",
},
ignorePatterns: [
"/lib/**/*", // Ignore built files.
],
plugins: [
"@typescript-eslint",
"import",
],
rules: {
"quotes": ["error", "double"],
"import/no-unresolved": 0,
"indent": ["error", 2],
},
};
15 changes: 15 additions & 0 deletions functions/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Compiled JavaScript files
lib/**/*.js
lib/**/*.js.map

# TypeScript v1 declaration files
typings/

# Node.js dependency directory
node_modules/

# debug files
firebase-debug.log

# env files
.env.*
34 changes: 34 additions & 0 deletions functions/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"name": "functions",
"scripts": {
"lint": "eslint --ext .js,.ts .",
"build": "tsc",
"build:watch": "tsc --watch",
"serve": "npm run build && firebase emulators:start --only functions",
"shell": "npm run build && firebase functions:shell",
"setapikey": "firebase functions:config:set google.api_key=$GOOGLE_API_KEY",
"start": "npm run shell",
"deploy": "firebase deploy --only functions",
"logs": "firebase functions:log"
},
"engines": {
"node": "18"
},
"main": "lib/index.js",
"dependencies": {
"axios": "^1.6.2",
"firebase-admin": "^11.8.0",
"firebase-functions": "^4.3.1",
"node-fetch": "^3.3.2"
},
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^5.12.0",
"@typescript-eslint/parser": "^5.12.0",
"eslint": "^8.9.0",
"eslint-config-google": "^0.14.0",
"eslint-plugin-import": "^2.25.4",
"firebase-functions-test": "^3.1.0",
"typescript": "^4.9.0"
},
"private": true
}
43 changes: 43 additions & 0 deletions functions/src/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import {onRequest} from "firebase-functions/v2/https";
import * as logger from "firebase-functions/logger";
import axios from "axios";

// We are using defineString instead of defineSecret because
// of an issue with the google cloud IAM authorizations.
// eslint-disable-next-line @typescript-eslint/no-var-requires
const {defineString} = require("firebase-functions/params");


const findPlaceFromTextUrl = "https://maps.googleapis.com/maps/api/place/findplacefromtext/json";

const GoogleMapsAPIKey = defineString("GOOGLE_API_KEY");

export const getDoctorRating = onRequest(async (request, response) => {
const {name, address} = request.query;

if (!name) {
response.status(400).send("Missing name parameter");
return;
}

const url = new URL(findPlaceFromTextUrl);

const params = new URLSearchParams({
input: `${name} ${address}`,
inputtype: "textquery",
fields: "place_id,name,rating,formatted_address",
key: GoogleMapsAPIKey.value(),
});

url.search = params.toString();

try {
const apiResponse = await axios.get(url.toString());
const data = apiResponse.data;
response.set("Access-Control-Allow-Origin", "https://www.doctolib.fr");
response.send(data);
} catch (error) {
logger.error("Error:", error);
response.status(500).send("Internal server error");
}
});
5 changes: 5 additions & 0 deletions functions/tsconfig.dev.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"include": [
".eslintrc.js"
]
}
15 changes: 15 additions & 0 deletions functions/tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"compilerOptions": {
"module": "commonjs",
"noImplicitReturns": true,
"noUnusedLocals": true,
"outDir": "lib",
"sourceMap": true,
"strict": true,
"target": "es2017"
},
"compileOnSave": true,
"include": [
"src"
]
}
Loading