Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for Julia <v1.6 #91

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented May 30, 2023

It's unlikely that users of Julia v1.0 would want the latest versions of packages, so it makes sense to restrict further development to v1.6. In any case, this is meant to be merged along with the next breaking release, so that v0.8 may still receive backported changes, if necessary.

@jishnub jishnub marked this pull request as draft May 30, 2023 07:31
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 91.66% and project coverage change: -0.12 ⚠️

Comparison is base (49bde1d) 94.98% compared to head (c7051c8) 94.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   94.98%   94.87%   -0.12%     
==========================================
  Files           7        7              
  Lines         798      819      +21     
==========================================
+ Hits          758      777      +19     
- Misses         40       42       +2     
Impacted Files Coverage Δ
src/ToeplitzMatrices.jl 87.50% <81.81%> (-4.81%) ⬇️
src/hankel.jl 96.20% <100.00%> (+0.04%) ⬆️
src/special.jl 99.33% <100.00%> (+0.03%) ⬆️
src/toeplitz.jl 97.56% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jishnub jishnub marked this pull request as ready for review June 9, 2023 14:25
@jishnub
Copy link
Member Author

jishnub commented Jun 9, 2023

On second thoughts, this isn't a breaking change, and someone who is using julia 1.0 is probably more concerned about stability rather than the latest versions of packages. I would suggest merging this, and moving on.

@dlfivefifty
Copy link
Member

The convention is that dropping old versions of Julia is a breaking change

@jishnub
Copy link
Member Author

jishnub commented Jun 16, 2023

It appears that colprac doesn't consider dropping support for older Julia versions as a breaking change, although it's a bit blurry for pre-1.0 packages. One needs to decide whether changes will be backported to v1.0, which I doubt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants