-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop support for Julia <v1.6 #91
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
==========================================
- Coverage 94.98% 94.87% -0.12%
==========================================
Files 7 7
Lines 798 819 +21
==========================================
+ Hits 758 777 +19
- Misses 40 42 +2
☔ View full report in Codecov by Sentry. |
On second thoughts, this isn't a breaking change, and someone who is using julia 1.0 is probably more concerned about stability rather than the latest versions of packages. I would suggest merging this, and moving on. |
The convention is that dropping old versions of Julia is a breaking change |
It appears that colprac doesn't consider dropping support for older Julia versions as a breaking change, although it's a bit blurry for pre-1.0 packages. One needs to decide whether changes will be backported to v1.0, which I doubt |
It's unlikely that users of Julia v1.0 would want the latest versions of packages, so it makes sense to restrict further development to v1.6. In any case, this is meant to be merged along with the next breaking release, so that v0.8 may still receive backported changes, if necessary.