Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): support CLI completion #2017

Merged
merged 1 commit into from
Sep 6, 2024
Merged

feat(cli): support CLI completion #2017

merged 1 commit into from
Sep 6, 2024

Conversation

pirtleshell
Copy link
Member

Description

enables the underlying cobra CLI completion scripts.

supported shells:

  • Bash
  • Zsh
  • Fish
  • PowerShell

this replaces (and un-hides) the previously-existing tendermint completion command that only supported bash & zsh.

see kava completion <shell> --help for specifics

❯ kava completion --help
Generate the autocompletion script for kava for the specified shell.
See each sub-command's help for details on how to use the generated script.

Usage:
  kava completion [command]

Available Commands:
  bash        Generate the autocompletion script for bash
  fish        Generate the autocompletion script for fish
  powershell  Generate the autocompletion script for powershell
  zsh         Generate the autocompletion script for zsh

Checklist

  • Changelog has been updated as necessary.

enables the underlying cobra CLI completion scripts.

supported shells:
* Bash
* Zsh
* Fish
* PowerShell

this replaces (and un-hides) the previously existing tendermint
completion command that only supported bash & zsh.

see `kava completion <shell> --help` for specifics
Copy link
Member

@nddeluca nddeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, tested with zsh & bash on debian

@pirtleshell pirtleshell merged commit 8ac4c5d into master Sep 6, 2024
12 checks passed
@pirtleshell pirtleshell deleted the rp-cli-completion branch September 6, 2024 18:58
mergify bot pushed a commit that referenced this pull request Sep 6, 2024
enables the underlying cobra CLI completion scripts.

supported shells:
* Bash
* Zsh
* Fish
* PowerShell

this replaces (and un-hides) the previously existing tendermint
completion command that only supported bash & zsh.

see `kava completion <shell> --help` for specifics

(cherry picked from commit 8ac4c5d)

# Conflicts:
#	CHANGELOG.md
#	cmd/kava/cmd/root.go
pirtleshell added a commit that referenced this pull request Oct 15, 2024
enables the underlying cobra CLI completion scripts.

supported shells:
* Bash
* Zsh
* Fish
* PowerShell

this replaces (and un-hides) the previously existing tendermint
completion command that only supported bash & zsh.

see `kava completion <shell> --help` for specifics

---------

Co-authored-by: Robert Pirtle <[email protected]>
pirtleshell added a commit that referenced this pull request Oct 25, 2024
enables the underlying cobra CLI completion scripts.

supported shells:
* Bash
* Zsh
* Fish
* PowerShell

this replaces (and un-hides) the previously existing tendermint
completion command that only supported bash & zsh.

see `kava completion <shell> --help` for specifics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants